From: Greg KH <gregkh@linuxfoundation.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tao Liu <taoliu828@163.com>,
paulb@nvidia.com, roid@nvidia.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH for-5.10] skbuff: Fix nfct leak on napi stolen
Date: Wed, 15 Mar 2023 08:43:21 +0100 [thread overview]
Message-ID: <ZBF3GaLSLsoHNpsh@kroah.com> (raw)
In-Reply-To: <20230314224312.41b6b248@kernel.org>
On Tue, Mar 14, 2023 at 10:43:12PM -0700, Jakub Kicinski wrote:
> On Tue, 14 Mar 2023 20:10:17 +0800 Tao Liu wrote:
> > Upstream commit [0] had fixed this issue, and backported to kernel 5.10.54.
> > However, nf_reset_ct() added in skb_release_head_state() instead of
> > napi_skb_free_stolen_head(), which lead to leakage still exist in 5.10.
> >
> > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984
> >
> > Fixes: 570341f10ecc ("skbuff: Release nfct refcount on napi stolen or re-used skbs"))
> > Signed-off-by: Tao Liu <taoliu828@163.com>
>
> I'm not sure Greg will spot this. Make sure you CC stable.
Ah, thanks, I missed it.
I've queued this up now, Tao, nice fix, sorry for getting the backport
wrong!
greg k-h
prev parent reply other threads:[~2023-03-15 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 12:10 [PATCH for-5.10] skbuff: Fix nfct leak on napi stolen Tao Liu
2023-03-15 5:43 ` Jakub Kicinski
2023-03-15 7:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBF3GaLSLsoHNpsh@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulb@nvidia.com \
--cc=roid@nvidia.com \
--cc=taoliu828@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).