From: Simon Horman <simon.horman@corigine.com>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next v2 4/4] net/sched: act_pedit: rate limit datapath messages
Date: Wed, 15 Mar 2023 16:53:59 +0100 [thread overview]
Message-ID: <ZBHqF7ZMs2YuksbO@corigine.com> (raw)
In-Reply-To: <20230314202448.603841-5-pctammela@mojatatu.com>
On Tue, Mar 14, 2023 at 05:24:48PM -0300, Pedro Tammela wrote:
> Unbounded info messages in the pedit datapath can flood the printk ring buffer quite easily
> depending on the action created. As these messages are informational, usually printing
> some, not all, is enough to bring attention to the real issue.
>
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-15 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 20:24 [PATCH net-next v2 0/4] net/sched: act_pedit: minor improvements Pedro Tammela
2023-03-14 20:24 ` [PATCH net-next v2 1/4] net/sched: act_pedit: use extack in 'ex' parsing errors Pedro Tammela
2023-03-15 15:51 ` Simon Horman
2023-03-17 19:15 ` Pedro Tammela
2023-03-14 20:24 ` [PATCH net-next v2 2/4] net/sched: act_pedit: check static offsets a priori Pedro Tammela
2023-03-15 15:52 ` Simon Horman
2023-03-14 20:24 ` [PATCH net-next v2 3/4] net/sched: act_pedit: remove extra check for key type Pedro Tammela
2023-03-15 15:53 ` Simon Horman
2023-03-14 20:24 ` [PATCH net-next v2 4/4] net/sched: act_pedit: rate limit datapath messages Pedro Tammela
2023-03-15 15:53 ` Simon Horman [this message]
2023-03-14 21:24 ` [PATCH net-next v2 0/4] net/sched: act_pedit: minor improvements Pedro Tammela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBHqF7ZMs2YuksbO@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).