From: Hangbin Liu <liuhangbin@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Davide Caratti <dcaratti@redhat.com>,
Pedro Tammela <pctammela@mojatatu.com>,
Marcelo Leitner <mleitner@redhat.com>,
Phil Sutter <psutter@redhat.com>
Subject: Re: [PATCHv2 net 0/2] net/sched: fix parsing of TCA_EXT_WARN_MSG for tc action
Date: Thu, 16 Mar 2023 18:22:08 +0800 [thread overview]
Message-ID: <ZBLt0MQeltIfTmVw@Laptop-X1> (raw)
In-Reply-To: <CAM0EoMkytZ26ZafxKBG3-EpXow_nWyrxye18Prr8JQ-VTVovpg@mail.gmail.com>
On Thu, Mar 16, 2023 at 05:45:28AM -0400, Jamal Hadi Salim wrote:
> On Wed, Mar 15, 2023 at 11:55 PM Hangbin Liu <liuhangbin@gmail.com> wrote:
> >
> > On Thu, Mar 16, 2023 at 11:37:51AM +0800, Hangbin Liu wrote:
> > > In my previous commit 0349b8779cc9 ("sched: add new attr TCA_EXT_WARN_MSG
> > > to report tc extact message") I didn't notice the tc action use different
> > > enum with filter. So we can't use TCA_EXT_WARN_MSG directly for tc action.
> > >
> > > Let's rever the previous fix 923b2e30dc9c ("net/sched: act_api: move
> > > TCA_EXT_WARN_MSG to the correct hierarchy") and add a new
> > > TCA_ROOT_EXT_WARN_MSG for tc action specifically.
> >
> > Sigh. Sorry I sent the mail too quick and forgot to add
> >
> > Reported-and-tested-by: Davide Caratti <dcaratti@redhat.com>
>
> For next time: instead of saying in the commit message "suggested by
> foo" specify it using "suggested-by: foo" semantics.
Sure, I will
Thanks
Hangbin
next prev parent reply other threads:[~2023-03-16 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 3:37 [PATCHv2 net 0/2] net/sched: fix parsing of TCA_EXT_WARN_MSG for tc action Hangbin Liu
2023-03-16 3:37 ` [PATCHv2 net 1/2] Revert "net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy" Hangbin Liu
2023-03-16 9:40 ` Jamal Hadi Salim
2023-03-16 3:37 ` [PATCHv2 net 2/2] net/sched: act_api: add specific EXT_WARN_MSG for tc action Hangbin Liu
2023-03-16 9:41 ` Jamal Hadi Salim
2023-03-16 3:55 ` [PATCHv2 net 0/2] net/sched: fix parsing of TCA_EXT_WARN_MSG " Hangbin Liu
2023-03-16 9:45 ` Jamal Hadi Salim
2023-03-16 10:22 ` Hangbin Liu [this message]
2023-03-17 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBLt0MQeltIfTmVw@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=psutter@redhat.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox