From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D64B9C7618D for ; Thu, 16 Mar 2023 13:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231142AbjCPNyU (ORCPT ); Thu, 16 Mar 2023 09:54:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230421AbjCPNx6 (ORCPT ); Thu, 16 Mar 2023 09:53:58 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47B99B78A1 for ; Thu, 16 Mar 2023 06:53:49 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id l15-20020a05600c4f0f00b003ed58a9a15eso1189970wmq.5 for ; Thu, 16 Mar 2023 06:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678974827; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tJUkcR5TLj/pckcV8NLJv4p0N2ALJ8mExf2txWHqrmk=; b=wWYYJ+ypcPdJWK8mFMkmqjjTg/4tNQcs0l/VDlsiczG9njmrsHE+8e2lHla18Brgd9 KH7eoUQG5yA5+ddWujlQEuiA1U+UbeBjJOkWb92cpyhwyt2nLoXbIItaXQ6DkpA1riAH 71uscclX9xlwsyG59l3cAyXvVnDJKd06TT5lHUfP1WVX/V+Ef9nIpmMHoMNzkAdGgE1u e+IFUWiMCBhjNJ1fSBWMBn6CykaHsiGAGNrxX8P+bYwLu/vUSURlzV4k3EArtB4VIthU nPGwF6G/A684ROdz1Dk1ew3/Ic1YeDs5ZvIkmCtlpdOYPsKxd7/0xJubMZ+QGvzMcpWd FuFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678974827; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tJUkcR5TLj/pckcV8NLJv4p0N2ALJ8mExf2txWHqrmk=; b=0NIkYDjL0OUxAqiMJGmMs4nti7j818KGcYMCZkn4Tsn3e7thuW0PPWuIhgEYrB2t+9 98LSrPuYSC7EAD3x5Yt8hH4yMhXmlvr6YoWeD4kkNNcfHLTSt/veXzOAQ7v2cIHmFii3 1lzimqDRLV9QRMbARSxu2iNeom+MI5uRczqqpOfeEZVnSqszE5VBD1yqOe3nzRVkf9iy acv0FmPz+GV63fIbsvZaD341OfXQrg5nV3pK70e20FA2nVJswodSXTpKyTVoipHGzqLb iEzVdCq1f3vP7AU6F6UIvcGhIdoGBLp66CJJXlhOBn5ayUpQEPNvmhNgin/4XUvdoyCV RtUA== X-Gm-Message-State: AO0yUKWZbZfrmuqzwiKG/qhLqoO9voW5vtn+qy/4r3DkB82cZ/EUGA5b 1Ms0TJB9V70Q7TzLq1ORg8SGQg== X-Google-Smtp-Source: AK7set+rqXMflrFeUbInvbGJbf4bdkNqSmGD9Ehmghl2MY/AZ9NJO7HEaQFrvUB9p731GmxgmKdHZg== X-Received: by 2002:a05:600c:35ce:b0:3e2:1368:e3a0 with SMTP id r14-20020a05600c35ce00b003e21368e3a0mr22297978wmq.18.1678974827774; Thu, 16 Mar 2023 06:53:47 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id p3-20020a05600c358300b003ed2eb5c2dcsm5370341wmq.43.2023.03.16.06.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 06:53:47 -0700 (PDT) Date: Thu, 16 Mar 2023 14:53:46 +0100 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Vadim Fedorenko , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Milena Olech , Michal Michalik Subject: Re: [PATCH RFC v6 2/6] dpll: Add DPLL framework base functions Message-ID: References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-3-vadfed@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230312022807.278528-3-vadfed@meta.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sun, Mar 12, 2023 at 03:28:03AM CET, vadfed@meta.com wrote: [...] >+ int (*state_on_pin_get)(const struct dpll_pin *pin, >+ const struct dpll_pin *parent_pin, >+ enum dpll_pin_state *state, >+ struct netlink_ext_ack *extack); >+ int (*state_on_dpll_get)(const struct dpll_pin *pin, >+ const struct dpll_device *dpll, >+ enum dpll_pin_state *state, >+ struct netlink_ext_ack *extack); Could this be rather called "state_on_device_get" or perhaps even better just "state_get" (in sync with "prio_set/get") ? This "od dpll" is a bit confusing, there is no such object. We have "device" and "pin". >+ int (*state_on_pin_set)(const struct dpll_pin *pin, >+ const struct dpll_pin *parent_pin, >+ const enum dpll_pin_state state, >+ struct netlink_ext_ack *extack); >+ int (*state_on_dpll_set)(const struct dpll_pin *pin, >+ const struct dpll_device *dpll, >+ const enum dpll_pin_state state, >+ struct netlink_ext_ack *extack); [...]