From: Simon Horman <simon.horman@corigine.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 10/10] tcp: preserve const qualifier in tcp_sk()
Date: Fri, 17 Mar 2023 18:12:24 +0100 [thread overview]
Message-ID: <ZBSfZZajdDkltzqQ@corigine.com> (raw)
In-Reply-To: <20230317155539.2552954-11-edumazet@google.com>
On Fri, Mar 17, 2023 at 03:55:39PM +0000, Eric Dumazet wrote:
> We can change tcp_sk() to propagate its argument const qualifier,
> thanks to container_of_const().
>
> We have two places where a const sock pointer has to be upgraded
> to a write one. We have been using const qualifier for lockless
> listeners to clearly identify points where writes could happen.
>
> Add tcp_sk_rw() helper to better document these.
>
> tcp_inbound_md5_hash(), __tcp_grow_window(), tcp_reset_check()
> and tcp_rack_reo_wnd() get an additional const qualififer
> for their @tp local variables.
>
> smc_check_reset_syn_req() also needs a similar change.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Upgrading gives me the heebie-jeebies, but ok.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-17 17:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 15:55 [PATCH net-next 00/10] net: better const qualifier awareness Eric Dumazet
2023-03-17 15:55 ` [PATCH net-next 01/10] udp: preserve const qualifier in udp_sk() Eric Dumazet
2023-03-17 16:33 ` Simon Horman
2023-03-17 15:55 ` [PATCH net-next 02/10] af_packet: preserve const qualifier in pkt_sk() Eric Dumazet
2023-03-17 16:33 ` Simon Horman
2023-03-17 15:55 ` [PATCH net-next 03/10] raw: preserve const qualifier in raw_sk() Eric Dumazet
2023-03-17 16:33 ` Simon Horman
2023-03-17 15:55 ` [PATCH net-next 04/10] ipv6: raw: preserve const qualifier in raw6_sk() Eric Dumazet
2023-03-17 16:35 ` Simon Horman
2023-03-17 15:55 ` [PATCH net-next 05/10] dccp: preserve const qualifier in dccp_sk() Eric Dumazet
2023-03-17 16:36 ` Simon Horman
2023-03-17 15:55 ` [PATCH net-next 06/10] af_unix: preserve const qualifier in unix_sk() Eric Dumazet
2023-03-17 16:37 ` Simon Horman
2023-03-17 15:55 ` [PATCH net-next 07/10] smc: preserve const qualifier in smc_sk() Eric Dumazet
2023-03-17 17:01 ` Simon Horman
2023-03-17 20:05 ` Wenjia Zhang
2023-03-17 15:55 ` [PATCH net-next 08/10] x25: preserve const qualifier in [a]x25_sk() Eric Dumazet
2023-03-17 17:03 ` Simon Horman
2023-03-17 15:55 ` [PATCH net-next 09/10] mptcp: preserve const qualifier in mptcp_sk() Eric Dumazet
2023-03-17 17:05 ` Simon Horman
2023-03-17 17:32 ` Matthieu Baerts
2023-03-17 17:47 ` Eric Dumazet
2023-03-17 17:59 ` Matthieu Baerts
2023-03-17 15:55 ` [PATCH net-next 10/10] tcp: preserve const qualifier in tcp_sk() Eric Dumazet
2023-03-17 17:12 ` Simon Horman [this message]
2023-03-18 12:30 ` [PATCH net-next 00/10] net: better const qualifier awareness patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBSfZZajdDkltzqQ@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).