From: Simon Horman <simon.horman@corigine.com>
To: Sean Anderson <seanga2@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net-next v3 8/9] net: sunhme: Inline error returns
Date: Sat, 18 Mar 2023 14:49:14 +0100 [thread overview]
Message-ID: <ZBXBWnAqsRECYYqH@corigine.com> (raw)
In-Reply-To: <8ea1c66e-e4c2-b30d-b8d0-9740ecb8bd6e@gmail.com>
On Wed, Mar 15, 2023 at 11:36:25AM -0400, Sean Anderson wrote:
> On 3/15/23 03:51, Jakub Kicinski wrote:
> > On Mon, 13 Mar 2023 20:36:12 -0400 Sean Anderson wrote:
> > > Fixes: 96c6e9faecf1 ("sunhme: forward the error code from pci_enable_device()")
> >
> > No such commit in our trees :(
>
> Ah, looks like I forgot this was bad when copying the other commit. It should be acb3f35f920b.
I agree that is the correct commit.
And the code changes look good to me.
But I wonder if the fix should be separated into another patch,
separate from the cleanup.
next prev parent reply other threads:[~2023-03-18 13:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 0:36 [PATCH net-next v3 0/9] net: sunhme: Probe/IRQ cleanups Sean Anderson
2023-03-14 0:36 ` [PATCH net-next v3 1/9] net: sunhme: Just restart autonegotiation if we can't bring the link up Sean Anderson
2023-03-15 8:20 ` Simon Horman
2023-03-15 15:35 ` Sean Anderson
2023-03-15 15:57 ` Simon Horman
2023-03-15 15:58 ` Simon Horman
2023-03-18 8:37 ` Simon Horman
2023-03-18 14:31 ` Sean Anderson
2023-03-14 0:36 ` [PATCH net-next v3 2/9] net: sunhme: Remove residual polling code Sean Anderson
2023-03-15 15:58 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 3/9] net: sunhme: Unify IRQ requesting Sean Anderson
2023-03-15 15:59 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 4/9] net: sunhme: Alphabetize includes Sean Anderson
2023-03-15 15:59 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 5/9] net: sunhme: Switch SBUS to devres Sean Anderson
2023-03-18 8:23 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 6/9] net: sunhme: Consolidate mac address initialization Sean Anderson
2023-03-18 8:58 ` Simon Horman
2023-03-18 9:00 ` Simon Horman
2023-03-18 15:31 ` Sean Anderson
2023-03-14 0:36 ` [PATCH net-next v3 7/9] net: sunhme: Clean up mac address init Sean Anderson
2023-03-18 9:03 ` Simon Horman
2023-03-18 15:43 ` Sean Anderson
2023-03-21 8:01 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 8/9] net: sunhme: Inline error returns Sean Anderson
2023-03-15 7:51 ` Jakub Kicinski
2023-03-15 15:36 ` Sean Anderson
2023-03-18 13:49 ` Simon Horman [this message]
2023-03-14 0:36 ` [PATCH net-next v3 9/9] net: sunhme: Consolidate common probe tasks Sean Anderson
2023-03-18 13:53 ` Simon Horman
2023-03-18 14:40 ` Sean Anderson
2023-03-21 8:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBXBWnAqsRECYYqH@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).