From: Johan Hovold <johan@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp-crd: add wifi calibration variant
Date: Mon, 20 Mar 2023 13:34:30 +0100 [thread overview]
Message-ID: <ZBhS1rV2+9ivOVUi@hovoldconsulting.com> (raw)
In-Reply-To: <87y1nrhazs.fsf@kernel.org>
On Mon, Mar 20, 2023 at 02:18:31PM +0200, Kalle Valo wrote:
> Johan Hovold <johan@kernel.org> writes:
> >> > > + qcom,ath11k-calibration-variant = "LE_X13S";
> >> > Intentional? Especially given Kalle's comment on bugzilla?
> >>
> >> Yes, it is intentional. The corresponding calibration data allows the
> >> wifi to be used on the CRD. I measure 150 MBits/s which may a bit lower
> >> than expected, but it's better than having no wifi at all.
> >
> > I was going back and forth about mentioning this in the commit message
> > and we could off on this one until someone confirms that the
> > corresponding calibration data can (or should) be used for the X13s.
Hopefully clear from context, but that was supposed to say "CRD" and not
"X13s"...
> > Note that there is no other match for
> >
> > 'bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=140'
> >
> > in the new board-2.bin.
>
> If the device in question is something else than Lenovo X13s, I would
> prefer that the variant is not set. Just in case we need different board
> files for different models. It's easy to add aliases to board-2.bin.
The sc8280xp CRD is the Qualcomm "compute" reference design for this
platform and is very similar to the X13s but they are not identical.
For ath11k and wcn6855, the CRD I have reports a chip_id of 2 and
"hw2.0", while the X13s reports chip_id 18 and "hw2.1".
The new board-2.bin notably adds two entries that match these chip_ids
but with the variant specified as "LE_X13S" for both.
> I need to check internally what board file should be used for this CRD.
> If the speed is only 150 Mbit/s I suspect it needs a different board
> file.
Sounds good. Let's drop this one for now then.
Johan
prev parent reply other threads:[~2023-03-20 12:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 10:46 [PATCH 0/3] arm64: dts: qcom: sc8280xp-x13s: add wifi calibration variant Johan Hovold
2023-03-20 10:46 ` [PATCH 1/3] dt-bindings: wireless: add ath11k pcie bindings Johan Hovold
2023-03-20 12:22 ` Kalle Valo
2023-03-20 12:42 ` Johan Hovold
2023-03-20 18:41 ` Kalle Valo
2023-03-21 8:22 ` Johan Hovold
2023-03-22 5:59 ` Kalle Valo
2023-03-21 8:14 ` Krzysztof Kozlowski
2023-03-21 8:16 ` Krzysztof Kozlowski
2023-03-21 8:27 ` Johan Hovold
2023-03-21 8:29 ` Krzysztof Kozlowski
2023-03-20 10:46 ` [PATCH 2/3] arm64: dts: qcom: sc8280xp-x13s: add wifi calibration variant Johan Hovold
2023-03-20 10:59 ` Konrad Dybcio
2023-03-20 12:15 ` Steev Klimaszewski
2023-03-20 10:46 ` [PATCH 3/3] arm64: dts: qcom: sc8280xp-crd: " Johan Hovold
2023-03-20 10:50 ` Konrad Dybcio
2023-03-20 10:55 ` Johan Hovold
2023-03-20 10:59 ` Konrad Dybcio
2023-03-20 11:07 ` Johan Hovold
2023-03-20 12:18 ` Kalle Valo
2023-03-20 12:34 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhS1rV2+9ivOVUi@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).