From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95959C6FD1D for ; Tue, 21 Mar 2023 12:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbjCUMUH (ORCPT ); Tue, 21 Mar 2023 08:20:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbjCUMTa (ORCPT ); Tue, 21 Mar 2023 08:19:30 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1B283A864 for ; Tue, 21 Mar 2023 05:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ElA6qLhNS3VR7AcrEFJ/HtgohrGfzckcBcX4VJm3vBY=; b=pGYqirDG2hnihyyFZHPSo6Du2Q zlEP2EheWG0ejZA5pf5+nUotRf4ChR092RUz1wFY5wNyHTATxGCgzqlCCbg9DAlTTzjX+V+AVRiWS ahmzs8d+D0qxTi8UaCgGuw0KpxmGUmFJy+FQtd26Bo+b7x+ozWKGmeXF0v8Dut/AKbt0qaosmhLgu JsK8iYMSxwe6P7nctgBhawXZFG5OsARl6NmGI2yyR3D6yZblhQhnvdDKUdDIvLtJKVvQVuBwTklH3 ZF+Cz8mvZfkJZ2/G0PYKFdxM8tUTiMK7Zoq977Hzti/EO7WriFe15Xkf7QsgXF/dSeC4xLuPMijBo Oa4ZbPOQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45534) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1peaxU-00014M-Uo; Tue, 21 Mar 2023 12:19:20 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1peaxT-0007j5-BQ; Tue, 21 Mar 2023 12:19:19 +0000 Date: Tue, 21 Mar 2023 12:19:19 +0000 From: "Russell King (Oracle)" To: Paolo Abeni Cc: Andrew Lunn , Heiner Kallweit , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jonathan McDowell , netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state() Message-ID: References: <9c2a6d714969b0151da4e3aaaf4fa2b7c4e9f616.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c2a6d714969b0151da4e3aaaf4fa2b7c4e9f616.camel@redhat.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 21, 2023 at 12:47:08PM +0100, Paolo Abeni wrote: > Hello, > > On Sun, 2023-03-19 at 12:33 +0000, Russell King (Oracle) wrote: > > pcs_get_state() implementations are not supposed to alter an_enabled. > > Remove this assignment. > > > > Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB") > > Signed-off-by: Russell King (Oracle) > > Any special reason to target the net-next tree? the fixes commit is > quite old, and this looks like a -net candidate to me?!? It's a correctness issue rather than a bug fix, so I don't see why it should be applied to a -rc kernel. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!