* [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()
@ 2023-03-19 12:33 Russell King (Oracle)
2023-03-21 11:47 ` Paolo Abeni
2023-03-21 12:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2023-03-19 12:33 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit
Cc: Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Jonathan McDowell, netdev
pcs_get_state() implementations are not supposed to alter an_enabled.
Remove this assignment.
Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/dsa/qca/qca8k-8xxx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
index 55df4479ea30..62810903f1b3 100644
--- a/drivers/net/dsa/qca/qca8k-8xxx.c
+++ b/drivers/net/dsa/qca/qca8k-8xxx.c
@@ -1483,7 +1483,6 @@ static void qca8k_pcs_get_state(struct phylink_pcs *pcs,
state->link = !!(reg & QCA8K_PORT_STATUS_LINK_UP);
state->an_complete = state->link;
- state->an_enabled = !!(reg & QCA8K_PORT_STATUS_LINK_AUTO);
state->duplex = (reg & QCA8K_PORT_STATUS_DUPLEX) ? DUPLEX_FULL :
DUPLEX_HALF;
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()
2023-03-19 12:33 [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state() Russell King (Oracle)
@ 2023-03-21 11:47 ` Paolo Abeni
2023-03-21 12:19 ` Russell King (Oracle)
2023-03-21 12:30 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Abeni @ 2023-03-21 11:47 UTC (permalink / raw)
To: Russell King (Oracle), Andrew Lunn, Heiner Kallweit
Cc: Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet,
Jakub Kicinski, Jonathan McDowell, netdev
Hello,
On Sun, 2023-03-19 at 12:33 +0000, Russell King (Oracle) wrote:
> pcs_get_state() implementations are not supposed to alter an_enabled.
> Remove this assignment.
>
> Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Any special reason to target the net-next tree? the fixes commit is
quite old, and this looks like a -net candidate to me?!?
Thanks!
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()
2023-03-21 11:47 ` Paolo Abeni
@ 2023-03-21 12:19 ` Russell King (Oracle)
0 siblings, 0 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2023-03-21 12:19 UTC (permalink / raw)
To: Paolo Abeni
Cc: Andrew Lunn, Heiner Kallweit, Florian Fainelli, Vladimir Oltean,
David S. Miller, Eric Dumazet, Jakub Kicinski, Jonathan McDowell,
netdev
On Tue, Mar 21, 2023 at 12:47:08PM +0100, Paolo Abeni wrote:
> Hello,
>
> On Sun, 2023-03-19 at 12:33 +0000, Russell King (Oracle) wrote:
> > pcs_get_state() implementations are not supposed to alter an_enabled.
> > Remove this assignment.
> >
> > Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> Any special reason to target the net-next tree? the fixes commit is
> quite old, and this looks like a -net candidate to me?!?
It's a correctness issue rather than a bug fix, so I don't see why it
should be applied to a -rc kernel.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()
2023-03-19 12:33 [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state() Russell King (Oracle)
2023-03-21 11:47 ` Paolo Abeni
@ 2023-03-21 12:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-21 12:30 UTC (permalink / raw)
To: Russell King
Cc: andrew, hkallweit1, f.fainelli, olteanv, davem, edumazet, kuba,
pabeni, noodles, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 19 Mar 2023 12:33:29 +0000 you wrote:
> pcs_get_state() implementations are not supposed to alter an_enabled.
> Remove this assignment.
>
> Fixes: b3591c2a3661 ("net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/dsa/qca/qca8k-8xxx.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state()
https://git.kernel.org/netdev/net-next/c/9ef70d0130f2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-21 12:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-19 12:33 [PATCH net-next] net: dsa: qca8k: remove assignment of an_enabled in pcs_get_state() Russell King (Oracle)
2023-03-21 11:47 ` Paolo Abeni
2023-03-21 12:19 ` Russell King (Oracle)
2023-03-21 12:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).