netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@corigine.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com,
	syzbot <syzkaller@googlegroups.com>
Subject: Re: [PATCH net] erspan: do not use skb_mac_header() in ndo_start_xmit()
Date: Tue, 21 Mar 2023 17:46:14 +0100	[thread overview]
Message-ID: <ZBnfVkpIftKsriqo@corigine.com> (raw)
In-Reply-To: <CANn89iJzniaHGYDWL4o8BWp+FBMH_RMaZuCzt+uh5gHicJQ+Pw@mail.gmail.com>

On Tue, Mar 21, 2023 at 09:26:45AM -0700, Eric Dumazet wrote:
> On Mon, Mar 20, 2023 at 11:53 PM Simon Horman <simon.horman@corigine.com> wrote:
> >
> 
> > Hi Eric,
> >
> > A quick grep seems to indicate there may be similar problems elsewhere.
> > I didn't check them in any detail and I'm wondering if you might have.
> 
> I have a patch series of three, but for net-next.
> 
> My plan is to remove skb_reset_mac_header() from __dev_queue_xmit :)

Excellent, thanks Eric.
I'll look for the other patches :)

  reply	other threads:[~2023-03-21 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 16:34 [PATCH net] erspan: do not use skb_mac_header() in ndo_start_xmit() Eric Dumazet
2023-03-21  6:53 ` Simon Horman
2023-03-21 16:26   ` Eric Dumazet
2023-03-21 16:46     ` Simon Horman [this message]
2023-03-22  4:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBnfVkpIftKsriqo@corigine.com \
    --to=simon.horman@corigine.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzkaller@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).