From: Hangbin Liu <haliu@redhat.com>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
simon.horman@corigine.com
Subject: Re: [PATCH net-next v3] net/sched: act_api: use the correct TCA_ACT attributes in dump
Date: Wed, 22 Mar 2023 09:38:04 +0800 [thread overview]
Message-ID: <ZBpb/MwzAO6yGcv4@Laptop-X1> (raw)
In-Reply-To: <20230321223345.1369859-1-pctammela@mojatatu.com>
On Tue, Mar 21, 2023 at 07:33:45PM -0300, Pedro Tammela wrote:
> 4 places in the act api code are using 'TCA_' definitions where they
> should be using 'TCA_ACT_', which is confusing for the reader, although
> functionally they are equivalent.
>
> Cc: Hangbin Liu <haliu@redhat.com>
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
> ---
Acked-by: Hangbin Liu <haliu@redhat.com>
next prev parent reply other threads:[~2023-03-22 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 22:33 [PATCH net-next v3] net/sched: act_api: use the correct TCA_ACT attributes in dump Pedro Tammela
2023-03-22 1:38 ` Hangbin Liu [this message]
2023-03-23 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBpb/MwzAO6yGcv4@Laptop-X1 \
--to=haliu@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=simon.horman@corigine.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox