From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E70FAC6FD1F for ; Wed, 22 Mar 2023 08:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbjCVI1C (ORCPT ); Wed, 22 Mar 2023 04:27:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230172AbjCVI1A (ORCPT ); Wed, 22 Mar 2023 04:27:00 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFB065CC24 for ; Wed, 22 Mar 2023 01:26:58 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5A50D5C021A; Wed, 22 Mar 2023 04:26:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 22 Mar 2023 04:26:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679473616; x=1679560016; bh=SzIhX6GvHnizN psaYaRgqmqGdVjvBEuASOUEmJvFwKI=; b=oJ1cds8zmncI2b5sz5/+Ff5SGWHo0 xodjtVd+1yMESZI4xXtiVhkRkBy6IHTQgWdihkSrSlNhc4duYfn/VCSTU/4ZTWMc Rs4xvjiGgc+r3A551+KncyrtDG7t9vMYIhuIkU4Ke9N+N5SxnSGl08ohpgH7C2Ty KoyKfBO3Wl3CyJjKEtdgiI7VcST7s3bGeVdzwg+/JWl8h5c4r0DYiVlvnRjrceU5 e6Eu8+Y+HrxPXFBSW9m9KQ0kfY55b5k7wPbtroGVevGp4js6uRfq49FCn7k0xQiP QPskt6QRHw7EJEnRjVSZDSbEf9GuzYPKrg+mNjTXeY8AF2w8S6/8fVUIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeguddguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkugho ucfutghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrg htthgvrhhnpedvudefveekheeugeeftddvveefgfduieefudeifefgleekheegleegjeej geeghfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Mar 2023 04:26:55 -0400 (EDT) Date: Wed, 22 Mar 2023 10:26:50 +0200 From: Ido Schimmel To: Vladimir Nikishkin Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eng.alaamohamedsoliman.am@gmail.com, gnault@redhat.com, razor@blackwall.org Subject: Re: [PATCH net-next v4] vxlan: try to send a packet normally if local bypass fails Message-ID: References: <20230322070414.21257-1-vladimir@nikishkin.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230322070414.21257-1-vladimir@nikishkin.pw> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 22, 2023 at 03:04:14PM +0800, Vladimir Nikishkin wrote: > --- a/Documentation/networking/vxlan.rst > +++ b/Documentation/networking/vxlan.rst > @@ -86,3 +86,16 @@ offloaded ports can be interrogated with `ethtool`:: > Types: geneve, vxlan-gpe > Entries (1): > port 1230, vxlan-gpe > + > +================= > +Sysctls > +================= > + > +One sysctl influences the behaviour of the vxlan driver. > + > + - `vxlan.disable_local_bypass` > + > +If set to 1, and if there is a packet destined to the local address, for which the > +driver cannot find a corresponding vni, it is forwarded to the userspace networking > +stack. This is useful if there is some userspace UDP tunnel waiting for such > +packets. Hi, I don't believe sysctl is the right interface for this. VXLAN options are usually / always added as netlink attributes. See ip-link man page under "VXLAN Type Support". Also, please add a selftest under tools/testing/selftests/net/. We already have a bunch of VXLAN tests that you can use as a reference. Thanks