From: Simon Horman <simon.horman@corigine.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 2/3] sch_cake: do not use skb_mac_header() in cake_overhead()
Date: Wed, 22 Mar 2023 12:26:08 +0100 [thread overview]
Message-ID: <ZBrl0FQHaHE6xTVP@corigine.com> (raw)
In-Reply-To: <20230321164519.1286357-3-edumazet@google.com>
On Tue, Mar 21, 2023 at 04:45:18PM +0000, Eric Dumazet wrote:
> We want to remove our use of skb_mac_header() in tx paths,
> eg remove skb_reset_mac_header() from __dev_queue_xmit().
>
> Idea is that ndo_start_xmit() can get the mac header
> simply looking at skb->data.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-22 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 16:45 [PATCH net-next 0/3] net: remove some skb_mac_header assumptions Eric Dumazet
2023-03-21 16:45 ` [PATCH net-next 1/3] net: do not use skb_mac_header() in qdisc_pkt_len_init() Eric Dumazet
2023-03-22 11:25 ` Simon Horman
2023-03-21 16:45 ` [PATCH net-next 2/3] sch_cake: do not use skb_mac_header() in cake_overhead() Eric Dumazet
2023-03-22 11:26 ` Simon Horman [this message]
2023-03-21 16:45 ` [PATCH net-next 3/3] net/sched: remove two skb_mac_header() uses Eric Dumazet
2023-03-22 11:26 ` Simon Horman
2023-03-21 17:13 ` [PATCH net-next 0/3] net: remove some skb_mac_header assumptions Vladimir Oltean
2023-03-21 18:41 ` Eric Dumazet
2023-03-23 5:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBrl0FQHaHE6xTVP@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).