From: Simon Horman <simon.horman@corigine.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add code for offloading flows from wlan devices
Date: Wed, 22 Mar 2023 15:29:21 +0100 [thread overview]
Message-ID: <ZBsQwVODyLg+x96e@corigine.com> (raw)
In-Reply-To: <ZBsK46vmNtjxJZH6@corigine.com>
On Wed, Mar 22, 2023 at 03:04:19PM +0100, Simon Horman wrote:
> On Tue, Mar 21, 2023 at 02:36:08PM +0100, Felix Fietkau wrote:
> > WED version 2 (on MT7986 and later) can offload flows originating from wireless
> > devices. In order to make that work, ndo_setup_tc needs to be implemented on
> > the netdevs. This adds the required code to offload flows coming in from WED,
> > while keeping track of the incoming wed index used for selecting the correct
> > PPE device.
> >
> > Signed-off-by: Felix Fietkau <nbd@nbd.name>
>
> Hi Felix,
>
> A few nits from my side.
>
> First, please reformat the patch description to have a maximum of 75 characters
> per line, as suggested by checkpatch.
>
> ...
One more.
This seems to conflict with:
[PATCH net 1/2] net: ethernet: mtk_eth_soc: fix flow block
So I guess this series needs to be rebased on that one one at some point.
next prev parent reply other threads:[~2023-03-22 14:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 13:36 [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add code for offloading flows from wlan devices Felix Fietkau
2023-03-21 13:36 ` [PATCH net-next 2/2] net: ethernet: mediatek: mtk_ppe: prefer newly added l2 flows over existing ones Felix Fietkau
2023-03-22 14:00 ` Simon Horman
2023-03-22 15:09 ` Felix Fietkau
2023-03-22 20:00 ` Simon Horman
2023-03-22 14:04 ` [PATCH net-next 1/2] net: ethernet: mtk_eth_soc: add code for offloading flows from wlan devices Simon Horman
2023-03-22 14:29 ` Simon Horman [this message]
2023-03-22 15:19 ` Felix Fietkau
2023-03-22 20:05 ` Simon Horman
2023-03-22 15:18 ` Felix Fietkau
2023-03-22 20:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBsQwVODyLg+x96e@corigine.com \
--to=simon.horman@corigine.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).