From: Greg KH <gregkh@linuxfoundation.org>
To: Szymon Heidrich <szymon.heidrich@gmail.com>
Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] net: usb: lan78xx: Limit packet length to skb->len
Date: Thu, 23 Mar 2023 17:29:44 +0100 [thread overview]
Message-ID: <ZBx+eGTSjRM8fvsf@kroah.com> (raw)
In-Reply-To: <20230317173606.91426-1-szymon.heidrich@gmail.com>
On Fri, Mar 17, 2023 at 06:36:06PM +0100, Szymon Heidrich wrote:
> Packet length retrieved from descriptor may be larger than
> the actual socket buffer length. In such case the cloned
> skb passed up the network stack will leak kernel memory contents.
>
> Additionally prevent integer underflow when size is less than
> ETH_FCS_LEN.
>
> Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
> Signed-off-by: Szymon Heidrich <szymon.heidrich@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>
the test robot did not report the fact that the packet length needed to
be limited :(
next prev parent reply other threads:[~2023-03-23 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 15:32 [PATCH] net: usb: lan78xx: Limit packet length to skb->len Szymon Heidrich
2023-03-17 16:46 ` kernel test robot
2023-03-17 17:36 ` [PATCH v2] " Szymon Heidrich
2023-03-18 3:32 ` kernel test robot
2023-03-18 5:27 ` Jakub Kicinski
2023-03-18 7:08 ` kernel test robot
2023-03-23 16:29 ` Greg KH [this message]
2023-03-23 20:57 ` Szymon Heidrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBx+eGTSjRM8fvsf@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=szymon.heidrich@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).