From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66BEFC6FD1C for ; Thu, 23 Mar 2023 14:00:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231586AbjCWOAE (ORCPT ); Thu, 23 Mar 2023 10:00:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231470AbjCWN7o (ORCPT ); Thu, 23 Mar 2023 09:59:44 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25E542A994; Thu, 23 Mar 2023 06:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679579957; x=1711115957; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ol1bIa7wEV9vbITom6nkTdY3Vf2gYZ26qp63G/qf9uw=; b=WoH6Q8vOac/q7/YRgSYATOukaynsQRcNyl97uCfwovTogF1ZBYBw1EUn y94hUOdJ+MIO6yI4gaAmHPAiMMonOfA2cu1E4jXTAaODkp4ITlwzl7BRH uob7l6LJmRs4QE6ifdABWEh9GLN4SEoAG92YPlO+voBNoK39KhZx715Qr g43/qYeH0ATLaPbfrtHl9o/KPGzEy8mUK0vY3ep3sgk6iwOw8PSBUfze0 tYFYsTTw1POBagNJIouKNCYLfmolWJ3QhueYH24aNdduapmYQblFuuGKr U0rrLibTrpeK0sYhDkrjPeRhS8VywHptFQqXA///XzVSLzCphA4Xc6tVV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="425772877" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="425772877" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 06:59:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="675717822" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="675717822" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 23 Mar 2023 06:59:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pfLTA-007WzI-0c; Thu, 23 Mar 2023 15:59:08 +0200 Date: Thu, 23 Mar 2023 15:59:07 +0200 From: Andy Shevchenko To: Russell King Cc: Andrew Lunn , Heiner Kallweit , Daniel Scally , "David S. Miller" , Eric Dumazet , Florian Fainelli , Greg Kroah-Hartman , Heikki Krogerus , Jakub Kicinski , linux-acpi@vger.kernel.org, netdev@vger.kernel.org, Paolo Abeni , "Rafael J. Wysocki" , Sakari Ailus , Vladimir Oltean Subject: Re: [PATCH RFC net-next 1/7] software node: allow named software node to be created Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 22, 2023 at 11:59:55AM +0000, Russell King wrote: > From: Vladimir Oltean > > Allow a named software node to be created, which is needed for software > nodes for a fixed-link specification for DSA. ... > +fwnode_create_named_software_node(const struct property_entry *properties, > + const struct fwnode_handle *parent, > + const char *name) > { > struct fwnode_handle *fwnode; > struct software_node *node; > @@ -930,6 +931,7 @@ fwnode_create_software_node(const struct property_entry *properties, > return ERR_CAST(node); > > node->parent = p ? p->node : NULL; > + node->name = name; The same question stays as before: how can we be sure that the name is unique and we won't have a collision? > fwnode = swnode_register(node, p, 1); > if (IS_ERR(fwnode)) > @@ -937,6 +939,14 @@ fwnode_create_software_node(const struct property_entry *properties, > > return fwnode; > } > +EXPORT_SYMBOL_GPL(fwnode_create_named_software_node); -- With Best Regards, Andy Shevchenko