From: Simon Horman <simon.horman@corigine.com>
To: Wei Yongjun <weiyongjun@huaweicloud.com>
Cc: Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Joseph CHAMG <josright123@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shay Agroskin <shayagr@amazon.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Nathan Huckleberry <nhuck@google.com>,
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
Wells Lu <wellslutw@gmail.com>, Leon Romanovsky <leon@kernel.org>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000
Date: Fri, 7 Apr 2023 12:36:21 +0200 [thread overview]
Message-ID: <ZC/yJdo163Lc4EBU@corigine.com> (raw)
In-Reply-To: <20230407094930.2633137-1-weiyongjun@huaweicloud.com>
On Fri, Apr 07, 2023 at 09:49:30AM +0000, Wei Yongjun wrote:
> [You don't often get email from weiyongjun@huaweicloud.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> All davicom drivers build need CONFIG_DM9000 is set, but this dependence
> is not correctly since dm9051 can be build as module without dm9000, switch
> to using CONFIG_NET_VENDOR_DAVICOM instead.
Thanks, this seems correct to me.
And I was able to exercise it successfully.
Maybe this is appropriate?
Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-04-07 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 9:49 [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000 Wei Yongjun
2023-04-07 10:36 ` Simon Horman [this message]
2023-04-11 13:26 ` Paolo Abeni
2023-04-11 15:02 ` Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC/yJdo163Lc4EBU@corigine.com \
--to=simon.horman@corigine.com \
--cc=alexandru.tachici@analog.com \
--cc=amit.kumar-mahapatra@amd.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=josright123@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhuck@google.com \
--cc=pabeni@redhat.com \
--cc=shayagr@amazon.com \
--cc=weiyongjun1@huawei.com \
--cc=weiyongjun@huaweicloud.com \
--cc=wellslutw@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).