* [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000
@ 2023-04-07 9:49 Wei Yongjun
2023-04-07 10:36 ` Simon Horman
2023-04-11 13:26 ` Paolo Abeni
0 siblings, 2 replies; 4+ messages in thread
From: Wei Yongjun @ 2023-04-07 9:49 UTC (permalink / raw)
To: Maciej Fijalkowski, Joseph CHAMG, Jeff Kirsher
Cc: Wei Yongjun, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, Shay Agroskin, Dmitry Torokhov,
Wolfram Sang, Nathan Huckleberry, Amit Kumar Mahapatra, Wells Lu,
Leon Romanovsky, Alexandru Tachici, Jiawen Wu, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
All davicom drivers build need CONFIG_DM9000 is set, but this dependence
is not correctly since dm9051 can be build as module without dm9000, switch
to using CONFIG_NET_VENDOR_DAVICOM instead.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
index 0d872d4efcd1..ee640885964e 100644
--- a/drivers/net/ethernet/Makefile
+++ b/drivers/net/ethernet/Makefile
@@ -32,7 +32,7 @@ obj-$(CONFIG_NET_VENDOR_CIRRUS) += cirrus/
obj-$(CONFIG_NET_VENDOR_CISCO) += cisco/
obj-$(CONFIG_NET_VENDOR_CORTINA) += cortina/
obj-$(CONFIG_CX_ECAT) += ec_bhf.o
-obj-$(CONFIG_DM9000) += davicom/
+obj-$(CONFIG_NET_VENDOR_DAVICOM) += davicom/
obj-$(CONFIG_DNET) += dnet.o
obj-$(CONFIG_NET_VENDOR_DEC) += dec/
obj-$(CONFIG_NET_VENDOR_DLINK) += dlink/
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000
2023-04-07 9:49 [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000 Wei Yongjun
@ 2023-04-07 10:36 ` Simon Horman
2023-04-11 13:26 ` Paolo Abeni
1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-04-07 10:36 UTC (permalink / raw)
To: Wei Yongjun
Cc: Maciej Fijalkowski, Joseph CHAMG, Jeff Kirsher, Wei Yongjun,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Shay Agroskin, Dmitry Torokhov, Wolfram Sang, Nathan Huckleberry,
Amit Kumar Mahapatra, Wells Lu, Leon Romanovsky,
Alexandru Tachici, Jiawen Wu, netdev
On Fri, Apr 07, 2023 at 09:49:30AM +0000, Wei Yongjun wrote:
> [You don't often get email from weiyongjun@huaweicloud.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> All davicom drivers build need CONFIG_DM9000 is set, but this dependence
> is not correctly since dm9051 can be build as module without dm9000, switch
> to using CONFIG_NET_VENDOR_DAVICOM instead.
Thanks, this seems correct to me.
And I was able to exercise it successfully.
Maybe this is appropriate?
Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000
2023-04-07 9:49 [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000 Wei Yongjun
2023-04-07 10:36 ` Simon Horman
@ 2023-04-11 13:26 ` Paolo Abeni
2023-04-11 15:02 ` Wei Yongjun
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Abeni @ 2023-04-11 13:26 UTC (permalink / raw)
To: Wei Yongjun, Maciej Fijalkowski, Joseph CHAMG, Jeff Kirsher
Cc: Wei Yongjun, David S. Miller, Eric Dumazet, Jakub Kicinski,
Simon Horman, Shay Agroskin, Dmitry Torokhov, Wolfram Sang,
Nathan Huckleberry, Amit Kumar Mahapatra, Wells Lu,
Leon Romanovsky, Alexandru Tachici, Jiawen Wu, netdev
On Fri, 2023-04-07 at 09:49 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> All davicom drivers build need CONFIG_DM9000 is set, but this dependence
> is not correctly since dm9051 can be build as module without dm9000, switch
> to using CONFIG_NET_VENDOR_DAVICOM instead.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/ethernet/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
> index 0d872d4efcd1..ee640885964e 100644
> --- a/drivers/net/ethernet/Makefile
> +++ b/drivers/net/ethernet/Makefile
> @@ -32,7 +32,7 @@ obj-$(CONFIG_NET_VENDOR_CIRRUS) += cirrus/
> obj-$(CONFIG_NET_VENDOR_CISCO) += cisco/
> obj-$(CONFIG_NET_VENDOR_CORTINA) += cortina/
> obj-$(CONFIG_CX_ECAT) += ec_bhf.o
> -obj-$(CONFIG_DM9000) += davicom/
> +obj-$(CONFIG_NET_VENDOR_DAVICOM) += davicom/
> obj-$(CONFIG_DNET) += dnet.o
> obj-$(CONFIG_NET_VENDOR_DEC) += dec/
> obj-$(CONFIG_NET_VENDOR_DLINK) += dlink/
Can you repost this for -net, including a suitable Fixes tag, as
suggested by Simon?
Thanks!
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000
2023-04-11 13:26 ` Paolo Abeni
@ 2023-04-11 15:02 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2023-04-11 15:02 UTC (permalink / raw)
To: Paolo Abeni, Wei Yongjun, Maciej Fijalkowski, Joseph CHAMG,
Jeff Kirsher
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Simon Horman,
Shay Agroskin, Dmitry Torokhov, Wolfram Sang, Nathan Huckleberry,
Amit Kumar Mahapatra, Wells Lu, Leon Romanovsky,
Alexandru Tachici, Jiawen Wu, netdev@vger.kernel.org
On 2023/4/11 21:26, Paolo Abeni wrote:
> On Fri, 2023-04-07 at 09:49 +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> All davicom drivers build need CONFIG_DM9000 is set, but this dependence
>> is not correctly since dm9051 can be build as module without dm9000, switch
>> to using CONFIG_NET_VENDOR_DAVICOM instead.
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/net/ethernet/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
>> index 0d872d4efcd1..ee640885964e 100644
>> --- a/drivers/net/ethernet/Makefile
>> +++ b/drivers/net/ethernet/Makefile
>> @@ -32,7 +32,7 @@ obj-$(CONFIG_NET_VENDOR_CIRRUS) += cirrus/
>> obj-$(CONFIG_NET_VENDOR_CISCO) += cisco/
>> obj-$(CONFIG_NET_VENDOR_CORTINA) += cortina/
>> obj-$(CONFIG_CX_ECAT) += ec_bhf.o
>> -obj-$(CONFIG_DM9000) += davicom/
>> +obj-$(CONFIG_NET_VENDOR_DAVICOM) += davicom/
>> obj-$(CONFIG_DNET) += dnet.o
>> obj-$(CONFIG_NET_VENDOR_DEC) += dec/
>> obj-$(CONFIG_NET_VENDOR_DLINK) += dlink/
>
> Can you repost this for -net, including a suitable Fixes tag, as
> suggested by Simon?
>
Sure, will repost after testing base on net tree.
Regards,
Wei Yongjun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-11 15:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 9:49 [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000 Wei Yongjun
2023-04-07 10:36 ` Simon Horman
2023-04-11 13:26 ` Paolo Abeni
2023-04-11 15:02 ` Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).