From: Simon Horman <simon.horman@corigine.com>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Amit Cohen <amcohen@nvidia.com>,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next 1/6] mlxsw: reg: Move 'mpsc' definition in 'mlxsw_reg_infos'
Date: Sun, 26 Mar 2023 15:59:45 +0200 [thread overview]
Message-ID: <ZCBP0WA06Z84xMCt@corigine.com> (raw)
In-Reply-To: <9ece6a3ddfc4f092fc07e912ace0efe9f882334f.1679502371.git.petrm@nvidia.com>
On Wed, Mar 22, 2023 at 05:49:30PM +0100, Petr Machata wrote:
> From: Amit Cohen <amcohen@nvidia.com>
>
> The array 'mlxsw_reg_infos' is ordered by registers' IDs. The ID of MPSC
> register is 0x9080, so it should be after MCDA (register ID 0x9063) and
> not after MTUTC (register ID 0x9055). Note that the register's fields are
> defined in the correct place in the file, only the definition in
> 'mlxsw_reg_infos' is wrong. This issue was found while adding new
> register which supposed to be before mpsc.
>
> Signed-off-by: Amit Cohen <amcohen@nvidia.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-26 14:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 16:49 [PATCH net-next 0/6] mlxsw: Add support for new reset flow Petr Machata
2023-03-22 16:49 ` [PATCH net-next 1/6] mlxsw: reg: Move 'mpsc' definition in 'mlxsw_reg_infos' Petr Machata
2023-03-26 13:59 ` Simon Horman [this message]
2023-03-22 16:49 ` [PATCH net-next 2/6] mlxsw: reg: Add Management Capabilities Mask Register Petr Machata
2023-03-26 14:00 ` Simon Horman
2023-03-26 14:02 ` Simon Horman
2023-03-27 9:35 ` Petr Machata
2023-03-27 9:53 ` Simon Horman
2023-03-22 16:49 ` [PATCH net-next 3/6] mlxsw: Extend MRSR pack() function to support new commands Petr Machata
2023-03-26 14:02 ` Simon Horman
2023-03-22 16:49 ` [PATCH net-next 4/6] mlxsw: pci: Rename mlxsw_pci_sw_reset() Petr Machata
2023-03-26 14:02 ` Simon Horman
2023-03-22 16:49 ` [PATCH net-next 5/6] mlxsw: pci: Move software reset code to a separate function Petr Machata
2023-03-26 14:03 ` Simon Horman
2023-03-22 16:49 ` [PATCH net-next 6/6] mlxsw: pci: Add support for new reset flow Petr Machata
2023-03-23 9:13 ` Petr Machata
2023-03-23 16:51 ` Bjorn Helgaas
2023-03-26 13:53 ` Ido Schimmel
2023-03-29 16:01 ` Bjorn Helgaas
2023-03-29 17:10 ` Alex Williamson
2023-03-30 8:26 ` Ido Schimmel
2023-03-30 18:49 ` Alex Williamson
2023-04-13 8:10 ` Ido Schimmel
2023-04-13 15:26 ` Jakub Kicinski
2023-04-13 10:26 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCBP0WA06Z84xMCt@corigine.com \
--to=simon.horman@corigine.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).