Netdev List
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Bobby Eshleman <bobbyeshleman@gmail.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
	Bobby Eshleman <bobby.eshleman@bytedance.com>,
	Bobby Eshleman <bobby.eshleman@gmail.com>,
	syzbot <syzbot+0bc015ebddc291a97116@syzkaller.appspotmail.com>,
	axboe@kernel.dk, davem@davemloft.net, edumazet@google.com,
	io-uring@vger.kernel.org, kuba@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	pabeni@redhat.com, stefanha@redhat.com,
	syzkaller-bugs@googlegroups.com,
	virtualization@lists.linux-foundation.org,
	Krasnov Arseniy <oxffffaa@gmail.com>,
	Krasnov Arseniy Vladimirovich <AVKrasnov@sberdevices.ru>
Subject: Re: [syzbot] [net?] [virt?] [io-uring?] [kvm?] BUG: soft lockup in vsock_connect
Date: Sun, 26 Mar 2023 12:20:33 -0700	[thread overview]
Message-ID: <ZCCbATwov4U+GBUv@pop-os.localdomain> (raw)
In-Reply-To: <ZBUGp5bvNuE3sK5g@bullseye>

On Sat, Mar 18, 2023 at 12:32:39AM +0000, Bobby Eshleman wrote:
> On Fri, Mar 24, 2023 at 09:38:38AM +0100, Stefano Garzarella wrote:
> > Hi Bobby,
> > FYI we have also this one, but it seems related to
> > syzbot+befff0a9536049e7902e@syzkaller.appspotmail.com
> > 
> > Thanks,
> > Stefano
> > 
> 
> Got it, I'll look into it.
> 

It seems you forgot to set skb->sk??

diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
index 957cdc01c8e8..d47ad27b409d 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -236,6 +236,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk,
        }

        virtio_transport_inc_tx_pkt(vvs, skb);
+       skb_set_owner_w(skb, sk_vsock(vsk));

        return t_ops->send_pkt(skb);
 }


  reply	other threads:[~2023-03-26 19:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24  0:52 [syzbot] [net?] [virt?] [io-uring?] [kvm?] BUG: soft lockup in vsock_connect syzbot
2023-03-24  8:38 ` Stefano Garzarella
2023-03-18  0:32   ` Bobby Eshleman
2023-03-26 19:20     ` Cong Wang [this message]
2023-03-27  9:07     ` Stefano Garzarella
2023-03-24 15:33 ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCCbATwov4U+GBUv@pop-os.localdomain \
    --to=xiyou.wangcong@gmail.com \
    --cc=AVKrasnov@sberdevices.ru \
    --cc=axboe@kernel.dk \
    --cc=bobby.eshleman@bytedance.com \
    --cc=bobby.eshleman@gmail.com \
    --cc=bobbyeshleman@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=io-uring@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oxffffaa@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=syzbot+0bc015ebddc291a97116@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox