From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 032D4C74A5B for ; Wed, 29 Mar 2023 10:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230253AbjC2K2E (ORCPT ); Wed, 29 Mar 2023 06:28:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbjC2K2C (ORCPT ); Wed, 29 Mar 2023 06:28:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 370E71BFC for ; Wed, 29 Mar 2023 03:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680085637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jd7WBwFIrNLOyJKQG/L4vTAs7GOnPYLmwP2mwUTLNMw=; b=HOZccEbq8Ev4foRutDJWD7BAyO5CT/PUhUAB9kJTAcQcBaP5tYGMSxOA6ch6EqhEzkih95 xl9h31cTQxFi6bh9syAEFeG8cMW/ZMv0Br10mRYFGtW+3GLhUo0wJP6uk/VQz4joysNVaf TagPYpqPxUbZzbft1JNIlxqcm9L+c2Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-671-uxOw9QE-NcyUG3HLHH_hbw-1; Wed, 29 Mar 2023 06:27:14 -0400 X-MC-Unique: uxOw9QE-NcyUG3HLHH_hbw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7CFF38030D1; Wed, 29 Mar 2023 10:27:13 +0000 (UTC) Received: from localhost (unknown [10.43.135.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 25E34492B00; Wed, 29 Mar 2023 10:27:12 +0000 (UTC) Date: Wed, 29 Mar 2023 12:27:11 +0200 From: Miroslav Lichvar To: Hangbin Liu Cc: netdev@vger.kernel.org, Jay Vosburgh , "David S . Miller" , Jakub Kicinski , Jonathan Toppins , Paolo Abeni , Eric Dumazet , Richard Cochran Subject: Re: [PATCH net-next] bonding: add software timestamping support Message-ID: References: <20230329031337.3444547-1-liuhangbin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230329031337.3444547-1-liuhangbin@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 29, 2023 at 11:13:37AM +0800, Hangbin Liu wrote: > At present, bonding attempts to obtain the timestamp (ts) information of > the active slave. However, this feature is only available for mode 1, 5, > and 6. For other modes, bonding doesn't even provide support for software > timestamping. To address this issue, let's call ethtool_op_get_ts_info > when there is no primary active slave. This will enable the use of software > timestamping for the bonding interface. Would it make sense to check if all devices in the bond support SOF_TIMESTAMPING_TX_SOFTWARE before returning it for the bond? Applications might expect that a SW TX timestamp will be always provided if the capability is reported. -- Miroslav Lichvar