From: Ido Schimmel <idosch@nvidia.com>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH net-next] selftests: rtnetlink: Fix do_test_address_proto()
Date: Thu, 30 Mar 2023 10:02:04 +0300 [thread overview]
Message-ID: <ZCUz7P66OGRJ9X2k@shredder> (raw)
In-Reply-To: <53a579bc883e1bf2fe490d58427cf22c2d1aa21f.1680102695.git.petrm@nvidia.com>
On Wed, Mar 29, 2023 at 05:24:53PM +0200, Petr Machata wrote:
> This selftest was introduced recently in the commit cited below. It misses
> several check_err() invocations to actually verify that the previous
> command succeeded. When these are added, the first one fails, because
> besides the addresses added by hand, there can be a link-local address
> added by the kernel. Adjust the check to expect at least three addresses
> instead of exactly three, and add the missing check_err's.
>
> Furthermore, the explanatory comments assume that the address with no
> protocol is $addr2, when in fact it is $addr3. Update the comments.
>
> Fixes: 6a414fd77f61 ("selftests: rtnetlink: Add an address proto test")
> Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2023-03-30 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 15:24 [PATCH net-next] selftests: rtnetlink: Fix do_test_address_proto() Petr Machata
2023-03-30 7:02 ` Ido Schimmel [this message]
2023-03-31 6:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCUz7P66OGRJ9X2k@shredder \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).