From: Simon Horman <simon.horman@corigine.com>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
wojciech.drewek@intel.com, piotr.raczynski@intel.com
Subject: Re: [PATCH net-next 3/4] ice: allow matching on metadata
Date: Sat, 1 Apr 2023 11:04:08 +0200 [thread overview]
Message-ID: <ZCfziCxSqccFPsCl@corigine.com> (raw)
In-Reply-To: <20230331105747.89612-4-michal.swiatkowski@linux.intel.com>
On Fri, Mar 31, 2023 at 12:57:46PM +0200, Michal Swiatkowski wrote:
> Add metadata matching criteria in the same place as protocol matching
> criteria. There is no need to add metadata as special words after
> parsing all lookups. Trade metadata in the same why as other lookups.
>
> The one difference between metadata lookups and protocol lookups is
> that metadata doesn't impact how the packets looks like. Because of that
> ignore it when filling testing packet.
>
> Match on tunnel type matadata always if tunnel type is different than
> TNL_LAST.
nit: checkpatch.pl --codespell tells me that 'matadata' is misspelt
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-04-01 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 10:57 [PATCH net-next 0/4] ice: allow matching on metadata Michal Swiatkowski
2023-03-31 10:57 ` [PATCH net-next 1/4] ice: define metadata to match in switch Michal Swiatkowski
2023-04-01 9:02 ` Simon Horman
2023-03-31 10:57 ` [PATCH net-next 2/4] ice: remove redundant Rx field from rule info Michal Swiatkowski
2023-04-01 9:03 ` Simon Horman
2023-03-31 10:57 ` [PATCH net-next 3/4] ice: allow matching on metadata Michal Swiatkowski
2023-04-01 9:04 ` Simon Horman [this message]
2023-03-31 10:57 ` [PATCH net-next 4/4] ice: use src VSI instead of src MAC in slow-path Michal Swiatkowski
2023-04-01 9:04 ` Simon Horman
2023-04-03 6:01 ` Michal Swiatkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCfziCxSqccFPsCl@corigine.com \
--to=simon.horman@corigine.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotr.raczynski@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).