From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33A4C76196 for ; Mon, 3 Apr 2023 15:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232250AbjDCPsr (ORCPT ); Mon, 3 Apr 2023 11:48:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231707AbjDCPso (ORCPT ); Mon, 3 Apr 2023 11:48:44 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2107.outbound.protection.outlook.com [40.107.96.107]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 427283ABA for ; Mon, 3 Apr 2023 08:48:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q12+MEEj1I1rfXUS2OWuGZLbEFrdgPZs1d3cnRXna4gppE5Mh8z2PI8YskypNu5hPbdOEzB7cWNC1p96wlNtcZ4rd0K2dhH/bPmWfpLQd0PsKTinlPz0u1ZM1uBAFYD33mX/H1EseyaHBGu7voOYJpftt6rbRuXEw2IXCJtpCsy/STO4V/e1YoQC/sPGbj4MSuklk1QOx6NU+VEKkmvgjb4K04/5OJBvisO3mgB4E9PJulnjCkV1vrNoOMemDVKfgGDHnpGCUbWfyds4Uz512z7xFmuNZj8bjVxXwj+djOa+SnZ3YkXswuQQnRkieqYrTNlgafDBMMswXY9PcHtUvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TO37BrA7xLUMa8QQIKi6DSSXlIs/MelYiX162x2TsU4=; b=SM+c+Yew44AfP1dwLi49xsu4/kkaCetDA1d9XZ5SfNM1DzpjZBlq2B4gJ2DK/t99mEO+MsLhh8gjQ/A8VLR/000zsoOF0BbOHQr1M3lxdKlfow+lrvOOmF6vnwsBgLEplAGfXt6p3repU0Pc+pRVZPQZxn5fqVS2Rxa1HiAKc8haaRTnBRzc/5oYm6jyOQhHSuvf8HwGy3u2C2oiZ5Pl/5WxntlX65C5e1uiFM0F+hzpYLrYigMo+uh9iaNkN9ugwOe/CESflNiYcda5ko3R1MAsbsnRNJpObVdL1HMKBWes+SbQODOn/jYCL9Kq3C2bw8sdOreXRMmeoyAcoiN+/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TO37BrA7xLUMa8QQIKi6DSSXlIs/MelYiX162x2TsU4=; b=clPz5F2YeDzpWoiLYxkPAHwU6Kgc06tfU2pjRaN8oQVwtZ/6Djag25FNfN6eTx/4v3TKzEvi59ecZBqEPwOkcNsRFWV7cYSyypZNRNe94iNO6KVIsdj5BplJm4gByY4PvPHDmBWRMskxdsy9Bgba4OUVoFhEowfqWtyDoAuKMis= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) by MW3PR13MB3993.namprd13.prod.outlook.com (2603:10b6:303:5c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 15:47:00 +0000 Received: from PH0PR13MB4842.namprd13.prod.outlook.com ([fe80::c506:5243:557e:82cb]) by PH0PR13MB4842.namprd13.prod.outlook.com ([fe80::c506:5243:557e:82cb%5]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 15:47:00 +0000 Date: Mon, 3 Apr 2023 17:46:52 +0200 From: Simon Horman To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Nobuhiro Iwamatsu , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH net-next 04/11] net: stmmac: dwmac-visconti: Convert to platform remove callback returning void Message-ID: References: <20230402143025.2524443-1-u.kleine-koenig@pengutronix.de> <20230402143025.2524443-5-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230402143025.2524443-5-u.kleine-koenig@pengutronix.de> X-ClientProxiedBy: AM3PR03CA0071.eurprd03.prod.outlook.com (2603:10a6:207:5::29) To PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR13MB4842:EE_|MW3PR13MB3993:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d364ae0-b272-43d9-a1f4-08db345aa96a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NBaZoMa9m3i5sRf1s9Qw2J3hhSEYqe8DjIiyBIYtzrWBsj6JmpZhDiDt1tfuAokDDTJhEGC7pEACQxf6i1kv3YBkMg22BBeWJRwsPqe1iFha2xSAiiucm5dVtja6E7ZExtLQrY/IhLubXUrdmws0WBU4MmtROIDuj6j08/QXqqWFoNXKG+nj0ENst4kIhOD5mZzY/kv3sahMuXknmtWxk2VjyzolL1pQF8YOAdvqNRDlY5peFDma2RkH1E7nEkcAKvgpfWg2cy8GxI3PKWgTdeKkV6c+A8AbZDKYp5C3PqUql2M6+hZlLUkBTLk6VWf0cGq20dFBvBicbjxon1PqOPRvfBPtbYZEtSXK7JqZnoTuX40NC3OMoDqmFf9kbsl8dtg+IgLvqc/zGUxRVodK8Z0X82qiRGyGGMwi3XvmyX0WA0YzDN/1tATcrWmiXt49d2mUXTBoIA1NZvum8cGwP+Gl/T5JhOmVMkTmEiHSg2t0d+Dibp0L/KkmU45LS+2mhWTIR2C11/Z9GEXIK9BRV5WIYESSzWywv3SBaMU9D3M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR13MB4842.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(346002)(39840400004)(376002)(136003)(366004)(451199021)(38100700002)(5660300002)(7416002)(44832011)(2616005)(83380400001)(54906003)(316002)(6486002)(966005)(478600001)(186003)(86362001)(6666004)(6512007)(6506007)(41300700001)(36756003)(4326008)(6916009)(8676002)(66946007)(66556008)(66476007)(8936002)(2906002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVBNbGdKUVFWbC9lNVFEY1R4Zll3S1A0cDNNZnZPWHZqOWFuYVVuc1l6U29h?= =?utf-8?B?a2Q3eFlUQk95K3RoS3VhMWh6VTFrMlFxeEF4TzVlOXd3cFUzMWNOL2loOFhW?= =?utf-8?B?dGpydDZwS1ZyYWNGYmlncS9Qamgvd2dwY0RkNTJaZlVmQlVkdVZHdDdQUm1V?= =?utf-8?B?Z2RaSVNhWHBGK3Ficktya1AzMnVtN2pNRE5wOVg0dUlpSHFJUzYxbHFWTE1Z?= =?utf-8?B?VXlzem80U2x3bm1qRWl5T1p5TUx6MjdXZ3cvYSt3dEI1N3U4QnlITitaSERG?= =?utf-8?B?Qmg4NXkvbFlRK0hsL2ozYnJTVmhza3dyenN3bEorN2ErbnlaOFg5bjJwQzM0?= =?utf-8?B?dW9MNnBRelhoblpnYzdYNDVZcVkxUHdpRFp3Yzh5SHNPY052R1hOV25XVk9O?= =?utf-8?B?L3ZkQ3RNVzlCckpKOHA5ZGNiVHRDZGYyMDkxay9GOG5kWUxHdVlsZEJNNExo?= =?utf-8?B?aU53Yll5U01vOVptcXB2N1c2NXAxWTRKc00vYmZRcVhiTFNwT0RvSnpEWHdL?= =?utf-8?B?OExVdGVYV3gwSGh0NmZYdC8xaFQweUx2cGdxTHcrMDlUTkhMekNvSTBEYnFF?= =?utf-8?B?enBGZFhqRUZHcUlweWVXT3ZocGpuWnk5TzNvYWhBcW4ySlFEVW9UNVJnYnlr?= =?utf-8?B?RzJUZFJ1bm9FZkl5c2pSSS9mMGVQTDZqaWdnNkdTV0NGMmJkMTUxUUh1ck54?= =?utf-8?B?S1FTekJNU2ZCS3F1OEpXNWlScnE4VnNCUmVDTm8xK05Ldzh2VFk0YldDai84?= =?utf-8?B?WTdZaWlhWVkyWnptQlpvdVNuZG9sUExad0VZYU80djhhOWdOVTVZNmtpaTRC?= =?utf-8?B?TW9sZjlRcEtha2h3YThXdWdWQmxOdTRKa2Z2RGg1VkE2ZEFjb1dORG9xYUFi?= =?utf-8?B?ZitZQWpad21vMndXNHhiMjJINk16MWFDdGJNVGk5MEdrUGN1REluZXk4UTdk?= =?utf-8?B?TUsySVhkTnhqYXpYbGZCS0xSc1lEdjAvUjZJQTJnamlPQS9hdThyRFE1MHM1?= =?utf-8?B?cGwzeGkxTHF1VUhjdDlxblYyK05yUmJ6LzVzNWlscEh0eTNpb2NKUlBvNms1?= =?utf-8?B?TGVNUnFSZmQrdEtDZnVvWHhVRDBvTlVwMDBoaGgwNlZVcUtrMFl0bTJDZTNY?= =?utf-8?B?czdvcHd1d1B3dkFIYWduVnVNSSt6cHl2aWQzS05nUDJEbEwzekhRUkYzZGhw?= =?utf-8?B?aVV3SUx4cENvTjQrM3gwOGx1NU1aMzFXOGpkUU9uMWx0MldzODdxRW9ORmtV?= =?utf-8?B?dGlzcWRPUzNpbE0wRHJBNXNKeWpkdXlTQ0xjSkhYNm1yQlRSVFEvUlk0bk5E?= =?utf-8?B?RWhKRTB5akJCRDhzRGI3RTA4dGE3MnJtdktGaFc0MGE3NHJYM1RQOCtRU1Yy?= =?utf-8?B?TlZUWGpKUzJJWUlScEFYdVN4NC94RVlOTFB1UFY3NkllOURUenFEbDd5Szhy?= =?utf-8?B?YXJlN1lNYnN3aVRHRHBBUW1iajVuYkY3N0IxVHV0VVozTzI3dExFRTVMMnhM?= =?utf-8?B?Um1wZXBTdGRveFFrSUtTdjJBbzFSSFNWSFhDZXgxa2daNzJKRElrMWh5Vy92?= =?utf-8?B?aXNpNDJPdWh4b0JrczZkeUMwZSs3Y0JXOTdGczJ3RmNaMWRObDI4R3U2dldo?= =?utf-8?B?MEFyZEhMckE0eG1hZ1J2a3NSWmtQWXlQSWJVakl2RVZ1d2tuMHR6TEpkVjFU?= =?utf-8?B?cDdjMTlPU05yV2J5OERscXdMeHZhNUsxZU8veUxLOGtrNnJTQkc4eDVzdDVw?= =?utf-8?B?bFNhR2lnRUR5OTZmTzdyQlZNeTJ1aTlHUHJPWUVCbm9UNTFtY2lvVGVTczB0?= =?utf-8?B?bHF5akxqWkF4REIwWEUwTUwwalFhMUdzcGNpL1IxZEpYODdvUzE1c0ZKOVVp?= =?utf-8?B?WElEdWdlWWtZUUtJMWJPYmlRdWxrSlBJNUVuZEdVOXN4YkQ3c1FjZE9DRWNV?= =?utf-8?B?Z2pWelJvY0VtWU5nK0FrRjRIblJkemh6ZnEzb012TzE4bll1YzRZNDh6QVBO?= =?utf-8?B?SDlESW9zVUZjQTNtSFljYVl3YUtqcDcvQm0zT0JabkNESlk3em0vSk5HZWdC?= =?utf-8?B?RnVkbHc2cWVEYkJZaGRjKytSbThybzcyV3FXLzBwWjhtZHlUNnlrdUdhWHFC?= =?utf-8?B?dVlXNlNvU3l4dnpXYXZrQzNXNVVmLy9XcExpZlJIWFQvSGt3TllYMnhadnJG?= =?utf-8?B?dVlqbEVxM0hHcWROZTZXYSt1akRESEZ1V1dZRnpGVGVvdVQvQWxEVlZIZkt2?= =?utf-8?B?UHRXWlcyblNJeUc0NUhoemN5ejVnPT0=?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d364ae0-b272-43d9-a1f4-08db345aa96a X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:47:00.2091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mIOXJ4jfs5ZEg/+BQDSg0pF+0yHrKyKmPI5PqGC3W5z3mHKzNJHjNOgtaHJuJzn9gHu6ntZeeeN8pM/2OOYtDt5jE9zt6wnXXGqsoES9OK8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR13MB3993 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Apr 02, 2023 at 04:30:18PM +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > index 7531fcd4ffe2..acbb284be174 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c > @@ -257,19 +257,16 @@ static int visconti_eth_dwmac_probe(struct platform_device *pdev) > return ret; > } > > -static int visconti_eth_dwmac_remove(struct platform_device *pdev) > +static void visconti_eth_dwmac_remove(struct platform_device *pdev) > { > struct net_device *ndev = platform_get_drvdata(pdev); > struct stmmac_priv *priv = netdev_priv(ndev); > - int err; As noted elsewhere, err is returned uninitialised since patch 02/11. Which will be fixed in v2 :) [1] https://lore.kernel.org/all/20230403055221.xugl42vub7ugo3tz@pengutronix.de/ That notwithstanding, Reviewed-by: Simon Horman > stmmac_pltfr_remove(pdev); > > visconti_eth_clock_remove(pdev); > > stmmac_remove_config_dt(pdev, priv->plat); > - > - return err; > } > > static const struct of_device_id visconti_eth_dwmac_match[] = { > @@ -280,7 +277,7 @@ MODULE_DEVICE_TABLE(of, visconti_eth_dwmac_match); > > static struct platform_driver visconti_eth_dwmac_driver = { > .probe = visconti_eth_dwmac_probe, > - .remove = visconti_eth_dwmac_remove, > + .remove_new = visconti_eth_dwmac_remove, > .driver = { > .name = "visconti-eth-dwmac", > .of_match_table = visconti_eth_dwmac_match, > -- > 2.39.2 >