From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5538C76188 for ; Mon, 3 Apr 2023 15:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232111AbjDCP4d (ORCPT ); Mon, 3 Apr 2023 11:56:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233114AbjDCP4U (ORCPT ); Mon, 3 Apr 2023 11:56:20 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2117.outbound.protection.outlook.com [40.107.223.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B003AAC for ; Mon, 3 Apr 2023 08:55:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IWe594003AkZmy1vwknqhEtyaXWhINyqdaBpoecM5OOMk0N17R7s0t9KolodtPjvaiNGdXmB195MkjwSCiKmS8QXdRpgOVWCsACBkcyr87cwBvURNQkYHaz1H7ttlrY14k2SWSyc5aR48qE5NQq4R/05H+IFR8yyB5BRRWo5FH+d0f5suNcVMqWbBSID6woD8eXt1HYZK31Pq4Qrg6o0qlfzqX0x+7VE2bN3ht7S7X7ZxDi3SfzAeXAoaBZr8wZe5u101JgfS1vBkGAE5rx9wbw4H/13ToW5APhHNyhSkS0uAvMAbZH0l6lgciGbWI2hjCy7bkq5Ay886e0voQbNJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J+YVYTGo2pr2JuszrU+NBVUV4x9UUygJDzD3MpMj8JE=; b=WLHbNqUa1ia1mummG5jxzqDIjbfiUC20qICKttrh5LPtmSBamlkrTOt0+HBwK8SF9z6EfI30nc5oKIkfzCB0+AHpWvFieHnmPweLv2Q5ModfTqGAmnFwqdpS8QevoJt9bS5vmOoHpqL0ZumUkGS9yZyIMyFrlkGQE51DbXkDmB4RM1BSQ8wHQ2C1IMGJAgVolnQYJTqmLFtMvDMgKOl7861zMoCtDS4tU1zlNo0GQMgTZghEUSZhqkV+THvPoagIcepzaeoPchWfTwqKQqV4xu2bOhWlbC2wRr9QutEZQg1tBGUIXFpNmdXY7l0ZI4JX8+eBJ9OHo0deKie4UsvPTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+YVYTGo2pr2JuszrU+NBVUV4x9UUygJDzD3MpMj8JE=; b=a8cKyMUJ+EzSt5q+3TrMVeTfcX5c8xmvpB4tpM4Bn02lqaRvqx51lk6FDuYvqL9xQ9UHV7mAZKr61H51Wt3pYnuPpPlYS70u+JQTy2a9GoPGc+Xs27cIAxGYg8VKPMuJHc2pB174e+1Qo4XbdZQO5BQ116loQRdjQ9p6xQ5m/ig= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) by CH2PR13MB3719.namprd13.prod.outlook.com (2603:10b6:610:97::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 15:55:30 +0000 Received: from PH0PR13MB4842.namprd13.prod.outlook.com ([fe80::c506:5243:557e:82cb]) by PH0PR13MB4842.namprd13.prod.outlook.com ([fe80::c506:5243:557e:82cb%5]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 15:55:30 +0000 Date: Mon, 3 Apr 2023 17:55:20 +0200 From: Simon Horman To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Shawn Guo , Sascha Hauer , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Vinod Koul , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Nobuhiro Iwamatsu , Matthias Brugger , Fabio Estevam , NXP Linux Team , Jerome Brunet , Martin Blumenstingl , Bhupesh Sharma , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, linux-amlogic@lists.infradead.org, linux-oxnas@groups.io, linux-sunxi@lists.linux.dev, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void Message-ID: References: <20230402143025.2524443-1-u.kleine-koenig@pengutronix.de> <20230402143025.2524443-2-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230402143025.2524443-2-u.kleine-koenig@pengutronix.de> X-ClientProxiedBy: AM0PR02CA0197.eurprd02.prod.outlook.com (2603:10a6:20b:28e::34) To PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR13MB4842:EE_|CH2PR13MB3719:EE_ X-MS-Office365-Filtering-Correlation-Id: 05cc14f8-0c86-4f96-a3d3-08db345bd974 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WDBP7MA6GGybR5O+n+MWC64viQtZhUZ6TchTFeP5Ztpeqb2dhVKRWElVLRXBMohaOnL/B+AYrs+QQ4gM1vTmgf87VamsfFtXQpBd766KGpXMHjXM72DjW1DBR4Ikg/U6OsMkBtO9UqhLAE91JAlwbEr5MNB9QuAE6fja+PgV74F7vLtXS8NgZGQxiEG5Afz6PuTa8byJJNJDQwqKLpAjoqus/VHhkXS6npla17SL4F2uDQaGtpcnHRzGVIgiAW9P7FjYgekcVo1mfv/z0rCng+3RRu+6yQDCtvPXtpF6Do8j2tQNXmBrQ9Sn+wsv2sK/xL056OerYhxsXUfb5EHFEgyWTg+Rfg3bjhBLRJZCpxzZQpcUvFbVkT+5udUTWF3mir7b6XV3N4qmSoseeebN23D+GrCPzWUngxMb7rOjhI9q4FxbEfWxJpqtahMz9VoKvq3fosQ/SzFGjtUVNRqNdohgYLF5Ri8iFXZ863q8nhBxsqv89cU+8fagkgx0xXduRROLPlaJkgVvQl4mZLR96ZVKhOOua3dfFHuo0D7/A7K9hPf0srFyKJJ6EXG0XtYK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR13MB4842.namprd13.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39830400003)(396003)(366004)(136003)(346002)(451199021)(6916009)(8676002)(4326008)(66946007)(66556008)(86362001)(66476007)(2906002)(41300700001)(316002)(54906003)(478600001)(36756003)(38100700002)(8936002)(2616005)(6486002)(5660300002)(6512007)(7406005)(7416002)(186003)(4744005)(6666004)(6506007)(44832011);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmhLQ2l4b0w2UGlHa3BURUVxS2tkdTk1WWpWbXN2dWJZaWxsaG1ISGwzRjZQ?= =?utf-8?B?V3dFNnNrNW9vdUZ6ODFPS3lNdVRjR1VrZktFWDlyMVY4cmFPb25FWDNpN3ZW?= =?utf-8?B?NzlqVko1TWlucElqNkFRMVNQdDF6UTd3U3ZsRlQ1alZWbFJNbTJhQ1dOTVFZ?= =?utf-8?B?U2swN1hYeVladUJXSGM5OEhjQmZjQlRXdXRmQjc0SUVZYzFoMUh5M1dCcEtB?= =?utf-8?B?RTRLcFBnWUJaUS8vVU5nSW40cFhUMnNoUU9NdjVyaU4vQUl5TmpRbkE3MWp3?= =?utf-8?B?RDN6OFBNa09xK2dQcmc0b29ZYW10M3AvWFhqZFBwYU82YVg3RnVnSlpTeTM3?= =?utf-8?B?dVVLbGtsMDEvSmM0V01hOVRtWHFMVFZPM1VLb3o2enk3MGNQQzdoYlhySU9O?= =?utf-8?B?TWZSbEc5YWpCTWpPZ1BrbWhlb1NkNUhVTHBlKzY4eXBMTHBScThvWUM3YUQw?= =?utf-8?B?cTdjQ2lBdEZnc0tyZ3ZBdE9JR29zdlRodllYUk5BajYvdGVPdWM4K2d2RURt?= =?utf-8?B?L1o2TDBlOEhrenNOR0JmTmxUTFowWDVQblJoRmtKc2tKcTQ5WUUveHN1dXpN?= =?utf-8?B?dzhzSFlvZFRmZzBDampvbjBsOFF6TEl2K055ZUdWZWsyc0JxVHhSRlpobmpq?= =?utf-8?B?SUZwNHNJWnZVRXdkaytxK2F2TCt2bXBuaGx3MTVuUDVsZ05iQTdyVDU5QUF5?= =?utf-8?B?ZUVZRUNFYU9XdGFCSmI2RVVQR2FyNkU3WXliRC94cks2cDV4U3JiS0dqc1Bu?= =?utf-8?B?VFlrZWx1dXM4UCtTMHlsZkFFaUNjaVJUbUlwSnBoblRhdEhHeU1jNEYzeFIy?= =?utf-8?B?VXhjMHo2bHRLeG9QNmw0Y3c3ODhITnY4bVR3a3QrZ3JKNFgrL1I2bjE1ZFIr?= =?utf-8?B?cXp3aUVjVDhRMHFaS0lHLzJxRzVaUTdybUYzQW10dXdLMWRZUnhGZUNmNENE?= =?utf-8?B?eW90bmxiZmZ5MG5scndhMkZwQ2J3bmJNZThybHlnNkxPKy9DeUZ5c0pJVnVO?= =?utf-8?B?Z04yMXZ4T1NVK20ySDB5RFB5Y2NwZ09SaUUxMFFRYmhLL0FrMTErVGZXRHRm?= =?utf-8?B?dldqNEQ5S21IKzR2MGJiSlptcUpJQW9ud09ZTzhwTGtsZ3ZwbmRieHgvNFhY?= =?utf-8?B?b1FWeUZZMFBQTTZpV3kyWkRpLzJaUGN3akZyTUJFcCt0YWlBMHhqWHBxbkFy?= =?utf-8?B?NDlrK0U2L2tkVytPWGIvamlOMzdWVnd6MVBSTkNzdnlYYk9XM3E0a2VveGJq?= =?utf-8?B?UXIxb1p2ZW9PUHhBakROckU1TEpQUWdKaHQ4RnhTYjUybmVmY3FhUTRid1l1?= =?utf-8?B?Tm84S1VURVU5LzhLRHpwVUhXbWdHNnJQS2p5NWt5bnNDa2FrazZTVVRBdnNz?= =?utf-8?B?Z0ZFZU9zYjFnMzRQUHFqenFxMWp0d3pMU2ExYmN3aTArL0o2SGxUYVlPOXcx?= =?utf-8?B?MWZ5R3MxQTBpNEJzRTd4b0xoM0pnVkkrQk5sQkhOeXlYRW9tNkd4MlhRZXJn?= =?utf-8?B?REQzQzNoMkJuM3FGV28wLzk3cU1jVXpJSVRQeW4zYmg1cXhXcGwwUy9tYnFN?= =?utf-8?B?eTIrSHpDYmJndVZVdXV4MzN4UFJ0S2YrNHF4QlBzSmZ3UnFtK2tzek9qRG56?= =?utf-8?B?enRTVmpwT1Rablp1dUU0aVdUSE8yZWFMc2UvbXFnT0drNmVFdGNKSURSVlJ4?= =?utf-8?B?dzJZWTVtQ3NRY1ZqMUdGenIzZEQ3SlFNUnM4SmhtMDdVcFBUdHk0SEpuWCtS?= =?utf-8?B?aTNzZUNkN1RqNkxEMk92N0NmYmtGb3NIN3gyNHNDNUtNSkE5a0syU29BUThD?= =?utf-8?B?bmdvaVJqZGZzRVlSU1RQUlVtdXV2dm14SEhlUFB4OFZBR1hhdmtPanp0ZE8v?= =?utf-8?B?SFpXOW1qbS96UUJuVHZDWFJray9FY29qZjFURHZRemFaVFFlQkdQdG80SHQx?= =?utf-8?B?T3o4b2tzczJpR09mWEgxdmd4S2ZjbDJuSWlNMWJWRnB3MzBmeVJON0JpcjlQ?= =?utf-8?B?NFBpTG5tZVlqODl6clQwWWZmbS9qYjhJa0NvYXFVR3hWSUU5WUlad2dhZmJN?= =?utf-8?B?amtVd3o4ZXVoOE1aQkhuU1NIbXllTmdVSCs3WmRZZlJvQStDcENxOTdKVk5D?= =?utf-8?B?M3l1a25OV1F4MG11RHF0MnZ5eWZLYmFCelNrbk9mMWtDYS9iYlNLL3pvNjVo?= =?utf-8?B?RkZZeW5ya2p5MFNrR1BnYmc5eDcza0FFR3ExUEF1Q3Y0N2RIeGRlYzJzdjdr?= =?utf-8?B?R0RVejRpN2N6YTNVdU05L1R3bHJnPT0=?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05cc14f8-0c86-4f96-a3d3-08db345bd974 X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 15:55:30.1271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Mi9ouKvLIseYSWu+x4/dzhuaT4Kd3OVKmu3Yn7inqxlbAOfeIqnoTDZyBnyWeY9OITutOt71PTxLoBlQP+UZRyicvCOPgS/BGQYNhSem74I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3719 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Apr 02, 2023 at 04:30:15PM +0200, Uwe Kleine-König wrote: > The function returns zero unconditionally. Change it to return void instead > which simplifies some callers as error handing becomes unnecessary. > > The function is also used for some drivers as remove callback. Switch these > to the .remove_new() callback. For some others no error can happen in the > remove callback now, convert them to .remove_new(), too. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Simon Horman