From: Simon Horman <horms@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH RFC] net: qrtr: correct types of trace event parameters
Date: Mon, 3 Apr 2023 15:10:40 +0200 [thread overview]
Message-ID: <ZCrQUANiiJrYuc3t@kernel.org> (raw)
In-Reply-To: <20230403051436.GA4627@thinkpad>
On Mon, Apr 03, 2023 at 10:44:56AM +0530, Manivannan Sadhasivam wrote:
> On Sun, Apr 02, 2023 at 01:15:33PM +0200, Simon Horman wrote:
> > The arguments passed to the trace events are of type unsigned int,
> > however the signature of the events used __le32 parameters.
> >
> > I may be missing the point here, but sparse flagged this and it
> > does seem incorrect to me.
> >
> > net/qrtr/ns.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/qrtr.h):
> > ./include/trace/events/qrtr.h:11:1: warning: cast to restricted __le32
> > ./include/trace/events/qrtr.h:11:1: warning: restricted __le32 degrades to integer
> > ./include/trace/events/qrtr.h:11:1: warning: restricted __le32 degrades to integer
> > ... (a lot more similar warnings)
> > net/qrtr/ns.c:115:47: expected restricted __le32 [usertype] service
> > net/qrtr/ns.c:115:47: got unsigned int service
> > net/qrtr/ns.c:115:61: warning: incorrect type in argument 2 (different base types)
> > ... (a lot more similar warnings)
> >
>
> You are right. The actual arguments (service, instance, node, port) transferred/
> received over QRTR are in le32 as per the protocol. But in the NS driver, the
> arguments passed to the trace events are in the native endian (i.e) before
> getting typecased to le32 for transmission.
>
> And my intention was to trace the arguments in native endian format only. So
> this patch indeed fixes the issue.
>
> > Signed-off-by: Simon Horman <horms@kernel.org>
>
> Please add the fixes tag once you remove RFC,
>
> Fixes: dfddb54043f0 ("net: qrtr: Add tracepoint support")
>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Hi Manivannan,
thanks for your review.
I'll add the tags and drop the RFC designation.
next prev parent reply other threads:[~2023-04-03 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 11:15 [PATCH RFC] net: qrtr: correct types of trace event parameters Simon Horman
2023-04-03 5:14 ` Manivannan Sadhasivam
2023-04-03 13:10 ` Simon Horman [this message]
2023-04-04 8:20 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCrQUANiiJrYuc3t@kernel.org \
--to=horms@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).