* [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY
@ 2023-04-03 19:35 Heiner Kallweit
2023-04-03 19:54 ` Simon Horman
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Heiner Kallweit @ 2023-04-03 19:35 UTC (permalink / raw)
To: Jakub Kicinski, David Miller, Paolo Abeni, Eric Dumazet,
Andrew Lunn, Russell King - ARM Linux, Martin Blumenstingl,
Kevin Hilman, Jerome Brunet, Neil Armstrong
Cc: Chris Healy, netdev@vger.kernel.org,
open list:ARM/Amlogic Meson...,
linux-arm-kernel@lists.infradead.org
Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
recently added tunable support in the smsc driver.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/phy/meson-gxl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index 3dea7c752..bb9b33b6b 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
.read_status = lan87xx_read_status,
.config_intr = smsc_phy_config_intr,
.handle_interrupt = smsc_phy_handle_interrupt,
+
+ .get_tunable = smsc_phy_get_tunable,
+ .set_tunable = smsc_phy_set_tunable,
+
.suspend = genphy_suspend,
.resume = genphy_resume,
.read_mmd = genphy_read_mmd_unsupported,
--
2.40.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY
2023-04-03 19:35 [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY Heiner Kallweit
@ 2023-04-03 19:54 ` Simon Horman
2023-04-03 20:24 ` Chris Healy
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-04-03 19:54 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Jakub Kicinski, David Miller, Paolo Abeni, Eric Dumazet,
Andrew Lunn, Russell King - ARM Linux, Martin Blumenstingl,
Kevin Hilman, Jerome Brunet, Neil Armstrong, Chris Healy,
netdev@vger.kernel.org, open list:ARM/Amlogic Meson...,
linux-arm-kernel@lists.infradead.org
On Mon, Apr 03, 2023 at 09:35:46PM +0200, Heiner Kallweit wrote:
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY
2023-04-03 19:35 [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY Heiner Kallweit
2023-04-03 19:54 ` Simon Horman
@ 2023-04-03 20:24 ` Chris Healy
2023-04-03 20:32 ` Heiner Kallweit
2023-04-03 20:41 ` Martin Blumenstingl
2023-04-05 2:00 ` patchwork-bot+netdevbpf
3 siblings, 1 reply; 6+ messages in thread
From: Chris Healy @ 2023-04-03 20:24 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Jakub Kicinski, David Miller, Paolo Abeni, Eric Dumazet,
Andrew Lunn, Russell King - ARM Linux, Martin Blumenstingl,
Kevin Hilman, Jerome Brunet, Neil Armstrong,
netdev@vger.kernel.org, open list:ARM/Amlogic Meson...,
linux-arm-kernel@lists.infradead.org
On Mon, Apr 3, 2023 at 12:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/phy/meson-gxl.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
> index 3dea7c752..bb9b33b6b 100644
> --- a/drivers/net/phy/meson-gxl.c
> +++ b/drivers/net/phy/meson-gxl.c
> @@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
> .read_status = lan87xx_read_status,
> .config_intr = smsc_phy_config_intr,
> .handle_interrupt = smsc_phy_handle_interrupt,
> +
> + .get_tunable = smsc_phy_get_tunable,
> + .set_tunable = smsc_phy_set_tunable,
> +
> .suspend = genphy_suspend,
Why add the empty lines before and after the two new lines?
> .resume = genphy_resume,
> .read_mmd = genphy_read_mmd_unsupported,
> --
> 2.40.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY
2023-04-03 20:24 ` Chris Healy
@ 2023-04-03 20:32 ` Heiner Kallweit
0 siblings, 0 replies; 6+ messages in thread
From: Heiner Kallweit @ 2023-04-03 20:32 UTC (permalink / raw)
To: Chris Healy
Cc: Jakub Kicinski, David Miller, Paolo Abeni, Eric Dumazet,
Andrew Lunn, Russell King - ARM Linux, Martin Blumenstingl,
Kevin Hilman, Jerome Brunet, Neil Armstrong,
netdev@vger.kernel.org, open list:ARM/Amlogic Meson...,
linux-arm-kernel@lists.infradead.org
On 03.04.2023 22:24, Chris Healy wrote:
> On Mon, Apr 3, 2023 at 12:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
>> recently added tunable support in the smsc driver.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/net/phy/meson-gxl.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
>> index 3dea7c752..bb9b33b6b 100644
>> --- a/drivers/net/phy/meson-gxl.c
>> +++ b/drivers/net/phy/meson-gxl.c
>> @@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
>> .read_status = lan87xx_read_status,
>> .config_intr = smsc_phy_config_intr,
>> .handle_interrupt = smsc_phy_handle_interrupt,
>> +
>> + .get_tunable = smsc_phy_get_tunable,
>> + .set_tunable = smsc_phy_set_tunable,
>> +
>> .suspend = genphy_suspend,
> Why add the empty lines before and after the two new lines?
>
Just for readability, because these two entries belong together.
Sometimes it's a little hard to read if drivers have 10+ callbacks
in a flat list in different, arbitrary order.
>> .resume = genphy_resume,
>> .read_mmd = genphy_read_mmd_unsupported,
>> --
>> 2.40.0
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY
2023-04-03 19:35 [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY Heiner Kallweit
2023-04-03 19:54 ` Simon Horman
2023-04-03 20:24 ` Chris Healy
@ 2023-04-03 20:41 ` Martin Blumenstingl
2023-04-05 2:00 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 6+ messages in thread
From: Martin Blumenstingl @ 2023-04-03 20:41 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Jakub Kicinski, David Miller, Paolo Abeni, Eric Dumazet,
Andrew Lunn, Russell King - ARM Linux, Kevin Hilman,
Jerome Brunet, Neil Armstrong, Chris Healy,
netdev@vger.kernel.org, open list:ARM/Amlogic Meson...,
linux-arm-kernel@lists.infradead.org
On Mon, Apr 3, 2023 at 9:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY
2023-04-03 19:35 [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY Heiner Kallweit
` (2 preceding siblings ...)
2023-04-03 20:41 ` Martin Blumenstingl
@ 2023-04-05 2:00 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-05 2:00 UTC (permalink / raw)
To: Heiner Kallweit
Cc: kuba, davem, pabeni, edumazet, andrew, linux, martin.blumenstingl,
khilman, jbrunet, neil.armstrong, cphealy, netdev, linux-amlogic,
linux-arm-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 3 Apr 2023 21:35:46 +0200 you wrote:
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/phy/meson-gxl.c | 4 ++++
> 1 file changed, 4 insertions(+)
Here is the summary with links:
- [net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY
https://git.kernel.org/netdev/net-next/c/992e76908e92
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-05 2:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-03 19:35 [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY Heiner Kallweit
2023-04-03 19:54 ` Simon Horman
2023-04-03 20:24 ` Chris Healy
2023-04-03 20:32 ` Heiner Kallweit
2023-04-03 20:41 ` Martin Blumenstingl
2023-04-05 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).