[PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

[PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

[Heiner Kallweit]

Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
recently added tunable support in the smsc driver.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/meson-gxl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index 3dea7c752..bb9b33b6b 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
 		.read_status	= lan87xx_read_status,
 		.config_intr	= smsc_phy_config_intr,
 		.handle_interrupt = smsc_phy_handle_interrupt,
+
+		.get_tunable	= smsc_phy_get_tunable,
+		.set_tunable	= smsc_phy_set_tunable,
+
 		.suspend        = genphy_suspend,
 		.resume         = genphy_resume,
 		.read_mmd	= genphy_read_mmd_unsupported,
-- 
2.40.0

Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

[Simon Horman]

On Mon, Apr 03, 2023 at 09:35:46PM +0200, Heiner Kallweit wrote:
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

[Chris Healy]

On Mon, Apr 3, 2023 at 12:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/net/phy/meson-gxl.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
> index 3dea7c752..bb9b33b6b 100644
> --- a/drivers/net/phy/meson-gxl.c
> +++ b/drivers/net/phy/meson-gxl.c
> @@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
>                 .read_status    = lan87xx_read_status,
>                 .config_intr    = smsc_phy_config_intr,
>                 .handle_interrupt = smsc_phy_handle_interrupt,
> +
> +               .get_tunable    = smsc_phy_get_tunable,
> +               .set_tunable    = smsc_phy_set_tunable,
> +
>                 .suspend        = genphy_suspend,
Why add the empty lines before and after the two new lines?

>                 .resume         = genphy_resume,
>                 .read_mmd       = genphy_read_mmd_unsupported,
> --
> 2.40.0
>

Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

[Heiner Kallweit]

On 03.04.2023 22:24, Chris Healy wrote:
> On Mon, Apr 3, 2023 at 12:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
>> recently added tunable support in the smsc driver.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>  drivers/net/phy/meson-gxl.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
>> index 3dea7c752..bb9b33b6b 100644
>> --- a/drivers/net/phy/meson-gxl.c
>> +++ b/drivers/net/phy/meson-gxl.c
>> @@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
>>                 .read_status    = lan87xx_read_status,
>>                 .config_intr    = smsc_phy_config_intr,
>>                 .handle_interrupt = smsc_phy_handle_interrupt,
>> +
>> +               .get_tunable    = smsc_phy_get_tunable,
>> +               .set_tunable    = smsc_phy_set_tunable,
>> +
>>                 .suspend        = genphy_suspend,
> Why add the empty lines before and after the two new lines?
> 
Just for readability, because these two entries belong together.
Sometimes it's a little hard to read if drivers have 10+ callbacks
in a flat list in different, arbitrary order.

>>                 .resume         = genphy_resume,
>>                 .read_mmd       = genphy_read_mmd_unsupported,
>> --
>> 2.40.0
>>

Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

[Martin Blumenstingl]

On Mon, Apr 3, 2023 at 9:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 3 Apr 2023 21:35:46 +0200 you wrote:
> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
> recently added tunable support in the smsc driver.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/net/phy/meson-gxl.c | 4 ++++
>  1 file changed, 4 insertions(+)

Here is the summary with links:
  - [net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY
    https://git.kernel.org/netdev/net-next/c/992e76908e92

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html