public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Jonathan Toppins <jtoppins@redhat.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>
Subject: Re: [PATCH net 2/3] selftests: bonding: re-format bond option tests
Date: Tue, 4 Apr 2023 10:28:30 +0800	[thread overview]
Message-ID: <ZCuLTjZjg7pZqO0X@Laptop-X1> (raw)
In-Reply-To: <ZCZGDQezuxXJuMd5@Laptop-X1>

On Fri, Mar 31, 2023 at 10:31:47AM +0800, Hangbin Liu wrote:
> > > +++ b/tools/testing/selftests/drivers/net/bonding/bond_lib.sh
> > 
> > I like this idea, we might want to separate network topology from library
> > code however. That way a given test case can just include a predefined
> 
> Would you like to help explain more clear? Separate network topology to where?


Hi Jon, would you please help explain this part?

Thanks
Hangbin

> 
> > topology. A quick review of the test cases show a 2 node setup is the most
> > common across all test cases.
> 
> Liang suggested that with 2 clients we can test xmit_hash_policy. In
> client_create() I only create 1 client for current testing. We can add more
> clients in future.
> 
> Thanks
> Hangbin

  reply	other threads:[~2023-04-04  2:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 10:18 [PATCH net 0/3] bonding: fix ns validation on backup slaves Hangbin Liu
2023-03-29 10:18 ` [PATCH net 1/3] " Hangbin Liu
2023-03-30 16:46   ` Jonathan Toppins
2023-03-31  4:02   ` Jay Vosburgh
2023-03-29 10:18 ` [PATCH net 2/3] selftests: bonding: re-format bond option tests Hangbin Liu
2023-03-30 16:45   ` Jonathan Toppins
2023-03-31  2:31     ` Hangbin Liu
2023-04-04  2:28       ` Hangbin Liu [this message]
2023-04-04 16:34         ` Jonathan Toppins
2023-04-05  9:57           ` Hangbin Liu
2023-04-06  0:23             ` Jonathan Toppins
2023-03-31  3:55   ` Jay Vosburgh
2023-03-29 10:18 ` [PATCH net 3/3] selftests: bonding: add arp validate test Hangbin Liu
2023-03-30 16:48   ` Jonathan Toppins
2023-03-31  4:00   ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCuLTjZjg7pZqO0X@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=j.vosburgh@gmail.com \
    --cc=jtoppins@redhat.com \
    --cc=kuba@kernel.org \
    --cc=liali@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox