From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, Vladimir Oltean <vladimir.oltean@nxp.com>,
Alexander 'lynxis' Couzens <lynxis@fe80.eu>,
Chukun Pan <amadeus@jmu.edu.cn>, John Crispin <john@phrozen.org>
Subject: Re: Convention regarding SGMII in-band autonegotiation
Date: Tue, 4 Apr 2023 10:41:38 +0100 [thread overview]
Message-ID: <ZCvw0vOSkKMa2vlz@shell.armlinux.org.uk> (raw)
In-Reply-To: <ZCvqJAVjOdogEZKD@makrotopia.org>
On Tue, Apr 04, 2023 at 10:13:59AM +0100, Daniel Golle wrote:
> On Tue, Apr 04, 2023 at 08:31:12AM +0200, Heiner Kallweit wrote:
> > Ideas from the patches can be re-used. Some patches itself are not ready
> > for mainline (replace magic numbers with proper constants (as far as
> > documented by Realtek), inappropriate use of phy_modify_mmd_changed,
> > read_status() being wrong place for updating interface mode).
>
> Where is updating the interface mode supposed to happen?
I think Heiner may be confused.
The interface mode update can _only_ happen in read_status(). It's just
another parameter that the PHY changes as a result of media
negotiation, just like "speed" and "duplex" etc.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-04-04 9:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 0:29 Convention regarding SGMII in-band autonegotiation Daniel Golle
2023-04-04 6:31 ` Heiner Kallweit
2023-04-04 9:13 ` Daniel Golle
2023-04-04 9:41 ` Russell King (Oracle) [this message]
2023-04-04 9:56 ` Heiner Kallweit
2023-04-04 10:16 ` Russell King (Oracle)
2023-04-04 14:13 ` Heiner Kallweit
2023-04-04 9:33 ` Russell King (Oracle)
2023-04-04 11:56 ` Daniel Golle
2023-04-04 14:46 ` Russell King (Oracle)
2023-04-04 19:05 ` Daniel Golle
2023-04-07 1:26 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCvw0vOSkKMa2vlz@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=amadeus@jmu.edu.cn \
--cc=daniel@makrotopia.org \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=lynxis@fe80.eu \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).