From: Simon Horman <simon.horman@corigine.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <YehezkelShB@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net: thunderbolt: Fix typo in comment
Date: Tue, 4 Apr 2023 21:25:14 +0200 [thread overview]
Message-ID: <ZCx5mnYKdaI4LJ4x@corigine.com> (raw)
In-Reply-To: <20230404053636.51597-3-mika.westerberg@linux.intel.com>
On Tue, Apr 04, 2023 at 08:36:36AM +0300, Mika Westerberg wrote:
> Should be UDP not UPD. No functional changes.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Looks good,
Reviewed-by: Simon Horman <simon.horman@corigine.com>
codespell tells me you also may want to consider:
$ codespell drivers/net/thunderbolt/main.c
drivers/net/thunderbolt/main.c:151: blongs ==> belongs
> ---
> drivers/net/thunderbolt/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/thunderbolt/main.c b/drivers/net/thunderbolt/main.c
> index 6a43ced74881..0ce501e34f3f 100644
> --- a/drivers/net/thunderbolt/main.c
> +++ b/drivers/net/thunderbolt/main.c
> @@ -1030,7 +1030,7 @@ static bool tbnet_xmit_csum_and_map(struct tbnet *net, struct sk_buff *skb,
> /* Data points on the beginning of packet.
> * Check is the checksum absolute place in the packet.
> * ipcso will update IP checksum.
> - * tucso will update TCP/UPD checksum.
> + * tucso will update TCP/UDP checksum.
> */
> if (protocol == htons(ETH_P_IP)) {
> __sum16 *ipcso = dest + ((void *)&(ip_hdr(skb)->check) - data);
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-04-04 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 5:36 [PATCH 0/2] net: thunderbolt: Fix for sparse warnings and typo Mika Westerberg
2023-04-04 5:36 ` [PATCH 1/2] net: thunderbolt: Fix sparse warnings Mika Westerberg
2023-04-04 19:37 ` Simon Horman
2023-04-05 8:45 ` Andy Shevchenko
2023-04-05 9:52 ` Mika Westerberg
2023-04-05 10:42 ` Andy Shevchenko
2023-04-05 12:28 ` Mika Westerberg
2023-04-04 5:36 ` [PATCH 2/2] net: thunderbolt: Fix typo in comment Mika Westerberg
2023-04-04 19:25 ` Simon Horman [this message]
2023-04-05 8:46 ` [PATCH 0/2] net: thunderbolt: Fix for sparse warnings and typo Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCx5mnYKdaI4LJ4x@corigine.com \
--to=simon.horman@corigine.com \
--cc=YehezkelShB@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).