From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, hawk@kernel.org,
ilias.apalodimas@linaro.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
lorenzo.bianconi@redhat.com, jdamato@fastly.com
Subject: Re: [PATCH net-next] net: page_pool: add pages and released_pages counters
Date: Tue, 18 Apr 2023 09:23:04 +0200 [thread overview]
Message-ID: <ZD5FWFik410qExT2@lore-desk> (raw)
In-Reply-To: <20230417163603.30be79bf@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
> On Mon, 17 Apr 2023 23:39:40 +0200 Lorenzo Bianconi wrote:
> > > Yup, that sounds better.
> >
> > ack, fine. I am now wondering if these counters are useful just during
> > debugging or even in the normal use-case.
>
> I was wondering about it too, FWIW, I think the most useful info is
> the number of outstanding references. But it may be a little too
> unflexible as a statistic. BPF attached to the trace point may be
> a better choice there, and tracepoints are already in place.
ack, I agree. Let's drop this patch in this case.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-04-18 7:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 21:46 [PATCH net-next] net: page_pool: add pages and released_pages counters Lorenzo Bianconi
2023-04-15 1:46 ` Jakub Kicinski
2023-04-15 11:16 ` Lorenzo Bianconi
2023-04-17 18:12 ` Jakub Kicinski
2023-04-17 21:39 ` Lorenzo Bianconi
2023-04-17 23:36 ` Jakub Kicinski
2023-04-18 7:23 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD5FWFik410qExT2@lore-desk \
--to=lorenzo@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).