netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Colin Foster <colin.foster@in-advantage.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Lee Jones <lee@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com
Subject: Re: [PATCH] regmap: allow upshifting register addresses before performing operations
Date: Fri, 7 Apr 2023 08:58:53 -0700	[thread overview]
Message-ID: <ZDA9vafqY0j0NhT3@euler> (raw)
In-Reply-To: <20230407152604.105467-1-maxime.chevallier@bootlin.com>

Hi Maxime,

On Fri, Apr 07, 2023 at 05:26:04PM +0200, Maxime Chevallier wrote:
>  	.reg_stride = 4,
> -	.reg_downshift = 2,
> +	.reg_shift = REGMAP_DOWNSHIFT(2),
>  	.val_bits = 32,

Looks great! Thanks. I tested this with a merge of net-next and
regmap-next + this patch.

Tested-by: Colin Foster <colin.foster@in-advantage.com>

  reply	other threads:[~2023-04-07 15:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 15:26 [PATCH] regmap: allow upshifting register addresses before performing operations Maxime Chevallier
2023-04-07 15:58 ` Colin Foster [this message]
2023-04-07 16:36   ` Maxime Chevallier
2023-04-07 16:25 ` Mark Brown
2023-04-07 16:37   ` Maxime Chevallier
2023-04-07 18:14 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZDA9vafqY0j0NhT3@euler \
    --to=colin.foster@in-advantage.com \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).