From: Simon Horman <simon.horman@corigine.com>
To: Sai Krishna <saikrishnag@marvell.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sgoutham@marvell.com,
gakula@marvell.com, richardcochran@gmail.com,
lcherian@marvell.com, jerinj@marvell.com, hkelam@marvell.com,
sbhatta@marvell.com, Ratheesh Kannoth <rkannoth@marvell.com>
Subject: Re: [net PATCH v2 5/7] octeontx2-af: Fix issues with NPC field hash extract
Date: Sat, 8 Apr 2023 17:21:19 +0200 [thread overview]
Message-ID: <ZDGGbyXDjrnoJRcd@corigine.com> (raw)
In-Reply-To: <20230407122344.4059-6-saikrishnag@marvell.com>
On Fri, Apr 07, 2023 at 05:53:42PM +0530, Sai Krishna wrote:
> From: Ratheesh Kannoth <rkannoth@marvell.com>
>
> 1. As per previous implementation, mask and control parameter to
> generate the field hash value was not passed to the caller program.
> Updated the secret key mbox to share that information as well,
> as a part of the fix.
> 2. Earlier implementation did not consider hash reduction of both
> source and destination IPv6 addresses. Only source IPv6 address
> was considered. This fix solves that and provides option to hash
> reduce both source and destination IPv6 addresses.
> 3. Fix endianness issue during hash reduction while storing the IPv6
> source/destination address as hash keys.
> 4. Configure hardware parser based on hash extract feature enable flag
> for IPv6.
Hi Sai and Ratheesh,
there is a lot going on here.
Could you consider breaking this up into more than one patch?
next prev parent reply other threads:[~2023-04-08 15:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 12:23 [net PATCH v2 0/7] octeontx2: Miscellaneous fixes Sai Krishna
2023-04-07 12:23 ` [net PATCH v2 1/7] octeontx2-af: Secure APR table update with the lock Sai Krishna
2023-04-08 14:33 ` Simon Horman
2023-04-10 8:25 ` Sai Krishna Gajula
2023-04-07 12:23 ` [net PATCH v2 2/7] octeontx2-af: Fix start and end bit for scan config Sai Krishna
2023-04-08 14:40 ` Simon Horman
2023-04-10 8:39 ` Sai Krishna Gajula
2023-04-07 12:23 ` [net PATCH v2 3/7] octeontx2-af: Add validation for lmac type Sai Krishna
2023-04-08 14:42 ` Simon Horman
2023-04-09 17:30 ` Leon Romanovsky
2023-04-10 6:08 ` Sai Krishna Gajula
2023-04-07 12:23 ` [net PATCH v2 4/7] octeontx2-af: Update correct mask to filter IPv4 fragments Sai Krishna
2023-04-08 14:43 ` Simon Horman
2023-04-07 12:23 ` [net PATCH v2 5/7] octeontx2-af: Fix issues with NPC field hash extract Sai Krishna
2023-04-08 15:21 ` Simon Horman [this message]
2023-04-10 8:43 ` Sai Krishna Gajula
2023-04-07 12:23 ` [net PATCH v2 6/7] octeontx2-af: Skip PFs if not enabled Sai Krishna
2023-04-08 14:56 ` Simon Horman
2023-04-14 11:58 ` Sai Krishna Gajula
2023-04-07 12:23 ` [net PATCH v2 7/7] octeontx2-pf: Disable packet I/O for graceful exit Sai Krishna
2023-04-08 14:29 ` Simon Horman
2023-04-10 8:49 ` Sai Krishna Gajula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDGGbyXDjrnoJRcd@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rkannoth@marvell.com \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).