From: Simon Horman <simon.horman@corigine.com>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org, davem@davemloft.net,
willemdebruijn.kernel@gmail.com, andrew@lunn.ch,
sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
jerinj@marvell.com, sbhatta@marvell.com, naveenm@marvell.com,
edumazet@google.com, pabeni@redhat.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, maxtram95@gmail.com,
corbet@lwn.net
Subject: Re: [net-next Patch v9 0/6] octeontx2-pf: HTB offload support
Date: Tue, 11 Apr 2023 19:42:09 +0200 [thread overview]
Message-ID: <ZDWb8QyRITjf4nKw@corigine.com> (raw)
In-Reply-To: <20230411090359.5134-1-hkelam@marvell.com>
On Tue, Apr 11, 2023 at 02:33:53PM +0530, Hariprasad Kelam wrote:
> octeontx2 silicon and CN10K transmit interface consists of five
> transmit levels starting from MDQ, TL4 to TL1. Once packets are
> submitted to MDQ, hardware picks all active MDQs using strict
> priority, and MDQs having the same priority level are chosen using
> round robin. Each packet will traverse MDQ, TL4 to TL1 levels.
> Each level contains an array of queues to support scheduling and
> shaping.
>
> As HTB supports classful queuing mechanism by supporting rate and
> ceil and allow the user to control the absolute bandwidth to
> particular classes of traffic the same can be achieved by
> configuring shapers and schedulers on different transmit levels.
>
> This series of patches adds support for HTB offload,
>
> Patch1: Allow strict priority parameter in HTB offload mode.
>
> Patch2: Rename existing total tx queues for better readability
>
> Patch3: defines APIs such that the driver can dynamically initialize/
> deinitialize the send queues.
>
> Patch4: Refactors transmit alloc/free calls as preparation for QOS
> offload code.
>
> Patch5: Adds actual HTB offload support.
>
> Patch6: Add documentation about htb offload flow in driver
>
> Hariprasad Kelam (3):
> octeontx2-pf: Rename tot_tx_queues to non_qos_queues
> octeontx2-pf: Refactor schedular queue alloc/free calls
> docs: octeontx2: Add Documentation for QOS
>
> Naveen Mamindlapalli (2):
> sch_htb: Allow HTB priority parameter in offload mode
> octeontx2-pf: Add support for HTB offload
>
> Subbaraya Sundeep (1):
> octeontx2-pf: qos send queues management
> -----
> v1 -> v2 :
> ensure other drivers won't affect by allowing 'prio'
> a parameter in htb offload mode.
>
> v2 -> v3 :
> 1. discard patch supporting devlink to configure TL1 round
> robin priority
> 2. replace NL_SET_ERR_MSG with NL_SET_ERR_MSG_MOD
> 3. use max3 instead of using max couple of times and use a better
> naming convention in send queue management code.
>
> v3 -> v4:
> 1. fix sparse warnings.
> 2. release mutex lock in error conditions.
>
> v4 -> v5:
> 1. fix pahole reported issues
> 2. add documentation for htb offload flow.
>
> v5 -> v6:
> 1. fix synchronization issues w.r.t hlist accessing
> from ndo_select_queue with rcu lock.
> 2. initialize qos related resources in device init.
>
> v6 -> v7:
> 1. fix erros reported by sparse and clang
>
> v7 -> v8:
> 1. cover letter header is malformed in last version.
> correct the cover letter
> v8 -> v9:
> 1. fix issues reported by smatch
Thanks. I checked and all issues I've reported are resolved.
next prev parent reply other threads:[~2023-04-11 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 9:03 [net-next Patch v9 0/6] octeontx2-pf: HTB offload support Hariprasad Kelam
2023-04-11 9:03 ` [net-next Patch v9 1/6] sch_htb: Allow HTB priority parameter in offload mode Hariprasad Kelam
2023-04-11 9:03 ` [net-next Patch v9 2/6] octeontx2-pf: Rename tot_tx_queues to non_qos_queues Hariprasad Kelam
2023-04-11 9:03 ` [net-next Patch v9 3/6] octeontx2-pf: qos send queues management Hariprasad Kelam
2023-04-11 9:03 ` [net-next Patch v9 4/6] octeontx2-pf: Refactor schedular queue alloc/free calls Hariprasad Kelam
2023-04-11 9:03 ` [net-next Patch v9 5/6] octeontx2-pf: Add support for HTB offload Hariprasad Kelam
2023-04-11 9:03 ` [net-next Patch v9 6/6] docs: octeontx2: Add Documentation for QOS Hariprasad Kelam
2023-04-11 17:42 ` Simon Horman [this message]
2023-04-13 1:27 ` [net-next Patch v9 0/6] octeontx2-pf: HTB offload support Jakub Kicinski
2023-04-13 8:53 ` Paolo Abeni
2023-04-24 6:47 ` Hariprasad Kelam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDWb8QyRITjf4nKw@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).