From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BAD3C77B76 for ; Wed, 12 Apr 2023 07:51:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbjDLHvm (ORCPT ); Wed, 12 Apr 2023 03:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbjDLHvl (ORCPT ); Wed, 12 Apr 2023 03:51:41 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07EED59FF; Wed, 12 Apr 2023 00:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WDasEsbrZhq6Y6NIih1XXwyVWPjBSJhq2DHjFCLMKyU=; b=fFqzuowZKwSTde6gG9QCNF4AeM wFNcTZtQuE/+ZJKEE1xmzTEG3bJCxaTw2LqZKs9ElseEkHen+IU6tU7YdSeOo1YWgc7QTqj0N1d+t 7deQ2ITZBv+gbdo5Uv5xrYSSGDNiBzUaI1OKVu5a1gmxeZXLuLhI7ML2VEqXQsSf5BW1+g91fFmil 9tVV+nxo69zsc4OoJ3zFxKQ34kU9hNDaXyoty9P/7PwGB6zLk2HdnCGAvwpm1J2Y+c2jk7ghylFOO gzAOm1mVq6vXnfsiSLvPH1R4oae1MHK+++Vp2SoZZAUrpKdiXWsDEJ69RZ3u139Bqw+vwoY5KQAMv Zps9iteg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48782) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pmVGJ-0007f7-CV; Wed, 12 Apr 2023 08:51:27 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pmVGD-0004wd-Rw; Wed, 12 Apr 2023 08:51:21 +0100 Date: Wed, 12 Apr 2023 08:51:21 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: davem@davemloft.net, Sit Michael Wei Hong , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , "linux-stm32 @ st-md-mailman . stormreply . com" , "alexis . lothore @ bootlin . com" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net] net: phylink: check for SFP bus presence in phylink_expects_phy Message-ID: References: <20230412074850.41260-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230412074850.41260-1-maxime.chevallier@bootlin.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 12, 2023 at 09:48:50AM +0200, Maxime Chevallier wrote: > When an SFP bus is present, we don't expect a PHY to be attached > directly from the MAC driver, it will be handled by phylink at SFP > attach time. If we have a SFP, then phylink should be configured for in-band mode. Maybe fix the firmware description instead? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!