From: Guillaume Nault <gnault@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Martin Willi <martin@strongswan.org>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] rtnetlink: Restore RTM_NEW/DELLINK notification behavior
Date: Wed, 12 Apr 2023 23:42:14 +0200 [thread overview]
Message-ID: <ZDcltmGmTr6XOlsN@debian> (raw)
In-Reply-To: <ZDavJCLutKC/+oHZ@Laptop-X1>
On Wed, Apr 12, 2023 at 09:16:20PM +0800, Hangbin Liu wrote:
> On Wed, Apr 12, 2023 at 11:21:33AM +0200, Martin Willi wrote:
> > Hi,
> >
> > > > Fixes: f3a63cce1b4f ("rtnetlink: Honour NLM_F_ECHO flag in rtnl_delete_link")
> > > > Fixes: d88e136cab37 ("rtnetlink: Honour NLM_F_ECHO flag in rtnl_newlink_create")
> > > > Signed-off-by: Martin Willi <martin@strongswan.org>
> > >
> > > Not sure if the Fixes tag should be
> > > 1d997f101307 ("rtnetlink: pass netlink message header and portid to rtnl_configure_link()")
> >
> > While this one adds the infrastructure, the discussed issue manifests
>
> Yes
>
> > only with the two commits above. Anyway, I'm fine with either, let me
> > know if I shall change it.
>
> In my understanding the above 2 commits only pass netlink header to
> rtnl_configure_link. The question code in 1d997f101307 didn't check if
> NLM_F_ECHO is honoured, as your commit pointed.
That's right, but personally I find it clearer to cite the commits that
brought the actual behaviour change.
> Thanks
> Hangbin
>
next prev parent reply other threads:[~2023-04-12 21:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 7:43 [PATCH net] rtnetlink: Restore RTM_NEW/DELLINK notification behavior Martin Willi
2023-04-11 9:52 ` Hangbin Liu
2023-04-12 9:21 ` Martin Willi
2023-04-12 13:16 ` Hangbin Liu
2023-04-12 21:42 ` Guillaume Nault [this message]
2023-04-13 2:46 ` Hangbin Liu
2023-04-12 21:38 ` Guillaume Nault
2023-04-13 2:48 ` Hangbin Liu
2023-04-13 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDcltmGmTr6XOlsN@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=martin@strongswan.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).