From: Ladislav Michl <oss-lists@triops.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-staging@lists.linux.dev, netdev@vger.kernel.org,
linux-mips@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: Re: [PATCH 0/3] staging: octeon: Convert to use phylink
Date: Thu, 13 Apr 2023 19:29:35 +0200 [thread overview]
Message-ID: <ZDg7/wUN5HzmJ5Zt@lenoch> (raw)
In-Reply-To: <6774ce75-196c-4b55-b159-bd39ee72542e@lunn.ch>
On Thu, Apr 13, 2023 at 07:12:29PM +0200, Andrew Lunn wrote:
> > > > However testing revealed some glitches:
> > > > 1. driver previously returned -EPROBE_DEFER when no phy was attached.
> > > > Phylink stack does not seem to do so, which end up with:
> > > >
> > > > Marvell PHY driver as a module:
> > > > octeon_ethernet 11800a0000000.pip eth0: configuring for inband/1000base-x link mode
> > > > octeon_ethernet 11800a0000000.pip eth1: PHY [8001180000001800:00] driver [Generic PHY] (irq=POLL)
> > > > octeon_ethernet 11800a0000000.pip eth1: configuring for phy/sgmii link mode
> > > > octeon_ethernet 11800a0000000.pip eth2: PHY [8001180000001800:01] driver [Generic PHY] (irq=POLL)
> > > > octeon_ethernet 11800a0000000.pip eth2: configuring for phy/sgmii link mode
> > > > octeon_ethernet 11800a0000000.pip eth0: switched to inband/sgmii link mode
> > > > octeon_ethernet 11800a0000000.pip eth0: PHY [i2c:sfp:16] driver [Marvell 88E1111] (irq=POLL)
> > > > octeon_ethernet 11800a0000000.pip eth3: PHY [8001180000001800:02] driver [Marvell 88E1340S] (irq=25)
> > > > octeon_ethernet 11800a0000000.pip eth3: configuring for phy/sgmii link mode
> > > > octeon_ethernet 11800a0000000.pip eth4: PHY [8001180000001800:03] driver [Marvell 88E1340S] (irq=25)
> > > > octeon_ethernet 11800a0000000.pip eth4: configuring for phy/sgmii link mode
> > > > octeon_ethernet 11800a0000000.pip eth1: Link is Up - 100Mbps/Full - flow control off
> > > >
> > > > Marvell PHY driver built-in:
> > > > octeon_ethernet 11800a0000000.pip eth0: configuring for inband/1000base-x link mode
> > > > octeon_ethernet 11800a0000000.pip eth1: PHY [8001180000001800:00] driver [Marvell 88E1340S] (irq=25)
> > > > octeon_ethernet 11800a0000000.pip eth1: configuring for phy/sgmii link mode
> > > > Error: Driver 'Marvell 88E1101' is already registered, aborting...
> > > > libphy: Marvell 88E1101: Error -16 in registering driver
> > > > Error: Driver 'Marvell 88E1101' is already registered, aborting...
> > > > libphy: Marvell 88E1101: Error -16 in registering driver
> > >
> > > This is very odd. But it could be a side effect of the
> > > compatible. Please try with it removed.
> >
> > That does not make any difference.
>
> Then i have no idea. I would suggest you add a WARN_ON() in
> phy_driver_register() so we get a backtrace. That might give a clue
> why it is getting registered multiple times.
And it indeed did. There was kernel/drivers/net/phy/marvell.ko
left in /lib/modules. Clearly my mistake, sorry for the noise and
thank you for help.
So now only that -EPROBE_DEFER handling in module case is waiting for
debugging.
ladis
prev parent reply other threads:[~2023-04-13 17:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 14:11 [PATCH 0/3] staging: octeon: Convert to use phylink Ladislav Michl
2023-04-13 14:13 ` [PATCH 1/3] staging: octeon: don't panic Ladislav Michl
2023-04-13 15:57 ` Andrew Lunn
2023-04-13 16:14 ` Ladislav Michl
2023-04-13 16:28 ` Andrew Lunn
2023-04-13 14:14 ` [PATCH 2/3] staging: octeon: avoid needless device allocation Ladislav Michl
2023-04-13 16:12 ` Andrew Lunn
2023-04-13 16:43 ` Ladislav Michl
2023-04-13 17:20 ` Andrew Lunn
2023-04-13 17:51 ` Ladislav Michl
2023-04-15 0:21 ` Ladislav Michl
2023-04-17 8:37 ` Dan Carpenter
2023-04-17 9:37 ` Ladislav Michl
2023-04-17 13:27 ` Andrew Lunn
2023-04-13 14:15 ` [RFC 3/3] staging: octeon: convert to use phylink Ladislav Michl
2023-04-13 15:35 ` Dan Carpenter
2023-04-13 16:04 ` Ladislav Michl
2023-04-13 16:10 ` Dan Carpenter
2023-04-13 16:17 ` Ladislav Michl
2023-04-13 15:45 ` [PATCH 0/3] staging: octeon: Convert " Andrew Lunn
2023-04-13 16:35 ` Ladislav Michl
2023-04-13 17:12 ` Andrew Lunn
2023-04-13 17:29 ` Ladislav Michl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDg7/wUN5HzmJ5Zt@lenoch \
--to=oss-lists@triops.cz \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-mips@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).