From: Ido Schimmel <idosch@idosch.org>
To: Zahari Doychev <zahari.doychev@linux.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
hmehrtens@maxlinear.com, aleksander.lobakin@intel.com,
simon.horman@corigine.com,
Zahari Doychev <zdoychev@maxlinear.com>
Subject: Re: [PATCH net-next v3 2/3] net: flower: add support for matching cfm fields
Date: Wed, 19 Apr 2023 18:20:57 +0300 [thread overview]
Message-ID: <ZEAG2aW78qbGHj//@shredder> (raw)
In-Reply-To: <20230417213233.525380-3-zahari.doychev@linux.com>
On Mon, Apr 17, 2023 at 11:32:32PM +0200, Zahari Doychev wrote:
> +static const struct nla_policy cfm_opt_policy[TCA_FLOWER_KEY_CFM_OPT_MAX] = {
> + [TCA_FLOWER_KEY_CFM_MD_LEVEL] = { .type = NLA_U8 },
> + [TCA_FLOWER_KEY_CFM_OPCODE] = { .type = NLA_U8 },
> +};
[...]
> +static int fl_set_key_cfm_md_level(struct nlattr **tb,
> + struct fl_flow_key *key,
> + struct fl_flow_key *mask,
> + struct netlink_ext_ack *extack)
> +{
> + u8 level;
> +
> + if (!tb[TCA_FLOWER_KEY_CFM_MD_LEVEL])
> + return 0;
> +
> + level = nla_get_u8(tb[TCA_FLOWER_KEY_CFM_MD_LEVEL]);
> + if (level & ~FIELD_MAX(FLOW_DIS_CFM_MDL_MASK)) {
> + NL_SET_ERR_MSG_ATTR(extack, tb[TCA_FLOWER_KEY_CFM_MD_LEVEL],
> + "cfm md level must be in [0, 7]");
> + return -EINVAL;
> + }
You should be able to replace this with NLA_POLICY_MAX()
> +
> + key->cfm.mdl_ver = FIELD_PREP(FLOW_DIS_CFM_MDL_MASK, level);
> + mask->cfm.mdl_ver = FLOW_DIS_CFM_MDL_MASK;
> +
> + return 0;
> +}
next prev parent reply other threads:[~2023-04-19 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 21:32 [PATCH net-next v3 0/3] net: flower: add cfm support Zahari Doychev
2023-04-17 21:32 ` [PATCH net-next v3 1/3] net: flow_dissector: add support for cfm packets Zahari Doychev
2023-04-19 14:42 ` Simon Horman
2023-04-17 21:32 ` [PATCH net-next v3 2/3] net: flower: add support for matching cfm fields Zahari Doychev
2023-04-19 14:40 ` Simon Horman
2023-04-19 14:51 ` Zahari Doychev
2023-04-19 15:20 ` Ido Schimmel [this message]
2023-04-19 16:39 ` Zahari Doychev
2023-04-17 21:32 ` [PATCH net-next v3 3/3] selftests: net: add tc flower cfm test Zahari Doychev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEAG2aW78qbGHj//@shredder \
--to=idosch@idosch.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hmehrtens@maxlinear.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zahari.doychev@linux.com \
--cc=zdoychev@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).