[PATCH iproute2] iplink: fix help of 'netns' arg

[PATCH iproute2] iplink: fix help of 'netns' arg

[Nicolas Dichtel]

'ip link set foo netns /proc/1/ns/net' is a valid command.
Let's update the doc accordingly.

Fixes: 0dc34c7713bb ("iproute2: Add processless network namespace support")
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 ip/iplink.c           | 4 ++--
 man/man8/ip-link.8.in | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ip/iplink.c b/ip/iplink.c
index a8da52f9f7ca..f7db17a9869d 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -63,7 +63,7 @@ void iplink_usage(void)
 			"		    [ mtu MTU ] [index IDX ]\n"
 			"		    [ numtxqueues QUEUE_COUNT ]\n"
 			"		    [ numrxqueues QUEUE_COUNT ]\n"
-			"		    [ netns { PID | NAME } ]\n"
+			"		    [ netns { PID | NAME | NETNS_FILE } ]\n"
 			"		    type TYPE [ ARGS ]\n"
 			"\n"
 			"	ip link delete { DEVICE | dev DEVICE | group DEVGROUP } type TYPE [ ARGS ]\n"
@@ -88,7 +88,7 @@ void iplink_usage(void)
 		"		[ address LLADDR ]\n"
 		"		[ broadcast LLADDR ]\n"
 		"		[ mtu MTU ]\n"
-		"		[ netns { PID | NAME } ]\n"
+		"		[ netns { PID | NAME | NETNS_FILE } ]\n"
 		"		[ link-netns NAME | link-netnsid ID ]\n"
 		"		[ alias NAME ]\n"
 		"		[ vf NUM [ mac LLADDR ]\n"
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index c8c656579364..5b8ddbf20359 100644
--- a/man/man8/ip-link.8.in
+++ b/man/man8/ip-link.8.in
@@ -49,7 +49,7 @@ ip-link \- network device configuration
 .IR BYTES " ]"
 .br
 .RB "[ " netns " {"
-.IR PID " | " NETNSNAME " } ]"
+.IR PID " | " NETNSNAME " | " NETNS_FILE " } ]"
 .br
 .BI type " TYPE"
 .RI "[ " ARGS " ]"
@@ -118,7 +118,7 @@ ip-link \- network device configuration
 .IR MTU " ]"
 .br
 .RB "[ " netns " {"
-.IR PID " | " NETNSNAME " } ]"
+.IR PID " | " NETNSNAME " | " NETNS_FILE " } ]"
 .br
 .RB "[ " link-netnsid
 .IR ID " ]"
-- 
2.39.2

Re: [PATCH iproute2] iplink: fix help of 'netns' arg

[Simon Horman]

On Tue, Apr 18, 2023 at 05:52:57PM +0200, Nicolas Dichtel wrote:
> 'ip link set foo netns /proc/1/ns/net' is a valid command.
> Let's update the doc accordingly.
> 
> Fixes: 0dc34c7713bb ("iproute2: Add processless network namespace support")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
>  ip/iplink.c           | 4 ++--
>  man/man8/ip-link.8.in | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/ip/iplink.c b/ip/iplink.c
> index a8da52f9f7ca..f7db17a9869d 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -63,7 +63,7 @@ void iplink_usage(void)
>  			"		    [ mtu MTU ] [index IDX ]\n"
>  			"		    [ numtxqueues QUEUE_COUNT ]\n"
>  			"		    [ numrxqueues QUEUE_COUNT ]\n"
> -			"		    [ netns { PID | NAME } ]\n"
> +			"		    [ netns { PID | NAME | NETNS_FILE } ]\n"
>  			"		    type TYPE [ ARGS ]\n"
>  			"\n"
>  			"	ip link delete { DEVICE | dev DEVICE | group DEVGROUP } type TYPE [ ARGS ]\n"
> @@ -88,7 +88,7 @@ void iplink_usage(void)
>  		"		[ address LLADDR ]\n"
>  		"		[ broadcast LLADDR ]\n"
>  		"		[ mtu MTU ]\n"
> -		"		[ netns { PID | NAME } ]\n"
> +		"		[ netns { PID | NAME | NETNS_FILE } ]\n"
>  		"		[ link-netns NAME | link-netnsid ID ]\n"
>  		"		[ alias NAME ]\n"
>  		"		[ vf NUM [ mac LLADDR ]\n"
> diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
> index c8c656579364..5b8ddbf20359 100644
> --- a/man/man8/ip-link.8.in
> +++ b/man/man8/ip-link.8.in
> @@ -49,7 +49,7 @@ ip-link \- network device configuration
>  .IR BYTES " ]"
>  .br
>  .RB "[ " netns " {"
> -.IR PID " | " NETNSNAME " } ]"
> +.IR PID " | " NETNSNAME " | " NETNS_FILE " } ]"
>  .br
>  .BI type " TYPE"
>  .RI "[ " ARGS " ]"
> @@ -118,7 +118,7 @@ ip-link \- network device configuration
>  .IR MTU " ]"
>  .br
>  .RB "[ " netns " {"
> -.IR PID " | " NETNSNAME " } ]"
> +.IR PID " | " NETNSNAME " | " NETNS_FILE " } ]"
>  .br
>  .RB "[ " link-netnsid
>  .IR ID " ]"

Hi Nicolas,

I think corresponding updates are also wanted for the set and add
subcommands in the DESCRIPTION section of tip-link.8.in.