From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A01C77B75 for ; Thu, 20 Apr 2023 00:43:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbjDTAnU (ORCPT ); Wed, 19 Apr 2023 20:43:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231241AbjDTAnT (ORCPT ); Wed, 19 Apr 2023 20:43:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4091FC3; Wed, 19 Apr 2023 17:43:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A82EE64356; Thu, 20 Apr 2023 00:43:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6316AC433EF; Thu, 20 Apr 2023 00:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681951396; bh=3TfSNpFYsuhxboTNumVnC5z5KX5U1yvWsKH2bQsrios=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XXm7+VqkcSuSfr75tU1q/8kzjPiLx9R2H7MT+z59XkHoh7y+n6BFa4ZsP/lSS5Op/ //Bv6mhBEG0ADIGRs0IlXQ3BaZIetBr+kiHpMJsEQTokgBUpsr+ZMyGeWAABqVMqyS DpcYp3RCl/TZuauDdZLOezqu25ymatHL/dcGQoOuLdyr8WxsAaI0LIAp/OOQmx6gIn z2LsaXJqe09nmyImfbN2gllFiUHdJMyUs7RkFgVmdWpaZCt+j1K4SoOPLkFjqsJ9co dN8k975bSGvdD/xJ8vsltoN/NJSDMcnfEC7Acm63wFzu2Vm8PyATtdCO2MWh2CIWWZ vDLMLd9U8VMkA== Date: Wed, 19 Apr 2023 17:43:11 -0700 From: Saeed Mahameed To: Jakub Kicinski Cc: Saeed Mahameed , Paul Moore , Leon Romanovsky , Linux regressions mailing list , Shay Drory , netdev@vger.kernel.org, selinux@vger.kernel.org, Tariq Toukan Subject: Re: Potential regression/bug in net/mlx5 driver Message-ID: References: <20230413152150.4b54d6f4@kernel.org> <20230413155139.22d3b2f4@kernel.org> <20230413202631.7e3bd713@kernel.org> <20230414173445.0800b7cf@kernel.org> <20230417083825.6e034c75@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20230417083825.6e034c75@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 17 Apr 08:38, Jakub Kicinski wrote: >On Fri, 14 Apr 2023 21:40:35 -0700 Saeed Mahameed wrote: >> >What do we do now, tho? If the main side effect of a revert is that >> >users of a newfangled device with an order of magnitude lower >> >deployment continue to see a warning/error in the logs - I'm leaning >> >towards applying it :( >> >> I tend to agree with you but let me check with the FW architect what he has >> to offer, either we provide a FW version check or another more accurate >> FW cap test that could solve the issue for everyone. If I don't come up with >> a solution by next Wednesday I will repost your revert in my next net PR >> on Wednesday. You can mark it awaiting-upstream for now, if that works for >> you. > >OK, sounds good. So I checked with Arch and we agreed that the only devices that need to expose this management PF are Bluefield chips, which have dedicated device IDs, and newer than the affected FW, so we can fix this by making the check more strict by testing device IDs as well. I will provide a patch by tomorrow, will let Paul test it first.