netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2] ip: bridge_slave: Fix help message indentation
@ 2023-04-19 15:43 Ido Schimmel
  2023-04-21 14:06 ` Simon Horman
  2023-04-22  3:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Ido Schimmel @ 2023-04-19 15:43 UTC (permalink / raw)
  To: netdev; +Cc: stephen, dsahern, netdev, Ido Schimmel

Use tabs instead of spaces to be consistent with the rest of the
options.

Before:

$ ip link help bridge_slave
Usage: ... bridge_slave [ fdb_flush ]
[...]
                        [ vlan_tunnel {on | off} ]
                        [ isolated {on | off} ]
                        [ locked {on | off} ]
                       [ mab {on | off} ]
                        [ backup_port DEVICE ] [ nobackup_port ]

After:

$ ip link help bridge_slave
Usage: ... bridge_slave [ fdb_flush ]
[...]
                        [ vlan_tunnel {on | off} ]
                        [ isolated {on | off} ]
                        [ locked {on | off} ]
                        [ mab {on | off} ]
                        [ backup_port DEVICE ] [ nobackup_port ]

Fixes: 05f1164fe811 ("bridge: link: Add MAC Authentication Bypass (MAB) support")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 ip/iplink_bridge_slave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/iplink_bridge_slave.c b/ip/iplink_bridge_slave.c
index 43b429485502..66a67961957f 100644
--- a/ip/iplink_bridge_slave.c
+++ b/ip/iplink_bridge_slave.c
@@ -40,7 +40,7 @@ static void print_explain(FILE *f)
 		"			[ vlan_tunnel {on | off} ]\n"
 		"			[ isolated {on | off} ]\n"
 		"			[ locked {on | off} ]\n"
-		"                       [ mab {on | off} ]\n"
+		"			[ mab {on | off} ]\n"
 		"			[ backup_port DEVICE ] [ nobackup_port ]\n"
 	);
 }
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH iproute2] ip: bridge_slave: Fix help message indentation
  2023-04-19 15:43 [PATCH iproute2] ip: bridge_slave: Fix help message indentation Ido Schimmel
@ 2023-04-21 14:06 ` Simon Horman
  2023-04-22  3:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-04-21 14:06 UTC (permalink / raw)
  To: Ido Schimmel; +Cc: netdev, stephen, dsahern, netdev

On Wed, Apr 19, 2023 at 06:43:59PM +0300, Ido Schimmel wrote:
> Use tabs instead of spaces to be consistent with the rest of the
> options.
> 
> Before:
> 
> $ ip link help bridge_slave
> Usage: ... bridge_slave [ fdb_flush ]
> [...]
>                         [ vlan_tunnel {on | off} ]
>                         [ isolated {on | off} ]
>                         [ locked {on | off} ]
>                        [ mab {on | off} ]
>                         [ backup_port DEVICE ] [ nobackup_port ]
> 
> After:
> 
> $ ip link help bridge_slave
> Usage: ... bridge_slave [ fdb_flush ]
> [...]
>                         [ vlan_tunnel {on | off} ]
>                         [ isolated {on | off} ]
>                         [ locked {on | off} ]
>                         [ mab {on | off} ]
>                         [ backup_port DEVICE ] [ nobackup_port ]
> 
> Fixes: 05f1164fe811 ("bridge: link: Add MAC Authentication Bypass (MAB) support")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH iproute2] ip: bridge_slave: Fix help message indentation
  2023-04-19 15:43 [PATCH iproute2] ip: bridge_slave: Fix help message indentation Ido Schimmel
  2023-04-21 14:06 ` Simon Horman
@ 2023-04-22  3:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-22  3:20 UTC (permalink / raw)
  To: Ido Schimmel; +Cc: netdev, stephen, dsahern, netdev

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Wed, 19 Apr 2023 18:43:59 +0300 you wrote:
> Use tabs instead of spaces to be consistent with the rest of the
> options.
> 
> Before:
> 
> $ ip link help bridge_slave
> Usage: ... bridge_slave [ fdb_flush ]
> [...]
>                         [ vlan_tunnel {on | off} ]
>                         [ isolated {on | off} ]
>                         [ locked {on | off} ]
>                        [ mab {on | off} ]
>                         [ backup_port DEVICE ] [ nobackup_port ]
> 
> [...]

Here is the summary with links:
  - [iproute2] ip: bridge_slave: Fix help message indentation
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=ed328120f47a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-22  3:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-19 15:43 [PATCH iproute2] ip: bridge_slave: Fix help message indentation Ido Schimmel
2023-04-21 14:06 ` Simon Horman
2023-04-22  3:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).