From: Simon Horman <simon.horman@corigine.com>
To: "Ramón Nordin Rodriguez" <ramon.nordin.rodriguez@ferroamp.se>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH v4] drivers/net/phy: add driver for Microchip LAN867x 10BASE-T1S PHY
Date: Fri, 21 Apr 2023 17:34:53 +0200 [thread overview]
Message-ID: <ZEKtHbO+gPcakNur@corigine.com> (raw)
In-Reply-To: <ZEFqFg9RO+Vsj8Kv@debian>
On Thu, Apr 20, 2023 at 06:36:38PM +0200, Ramón Nordin Rodriguez wrote:
> This patch adds support for the Microchip LAN867x 10BASE-T1S family
> (LAN8670/1/2). The driver supports P2MP with PLCA.
>
> Signed-off-by: Ramón Nordin Rodriguez <ramon.nordin.rodriguez@ferroamp.se>
...
> +static int lan867x_config_init(struct phy_device *phydev)
> +{
> + /* HW quirk: Microchip states in the application note (AN1699) for the phy
> + * that a set of read-modify-write (rmw) operations has to be performed
> + * on a set of seemingly magic registers.
> + * The result of these operations is just described as 'optimal performance'
> + * Microchip gives no explanation as to what these mmd regs do,
> + * in fact they are marked as reserved in the datasheet.
> + * It is unclear if phy_modify_mmd would be safe to use or if a write
> + * really has to happen to each register.
> + * In order to exacly conform to what is stated in the AN phy_write_mmd is
nit: s/exacly/exactly/
> + * used, which might then write the same value back as read + modified.
> + */
...
prev parent reply other threads:[~2023-04-21 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 16:36 [PATCH v4] drivers/net/phy: add driver for Microchip LAN867x 10BASE-T1S PHY Ramón Nordin Rodriguez
2023-04-20 16:49 ` Andrew Lunn
2023-04-20 17:26 ` Ramón Nordin Rodriguez
2023-04-21 6:44 ` Parthiban.Veerasooran
2023-04-21 7:29 ` Ramón Nordin Rodriguez
2023-04-21 7:53 ` Parthiban.Veerasooran
2023-04-21 12:39 ` Andrew Lunn
2023-04-21 15:34 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEKtHbO+gPcakNur@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=ramon.nordin.rodriguez@ferroamp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).