From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A08C7EE20 for ; Wed, 26 Apr 2023 15:07:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241104AbjDZPHL (ORCPT ); Wed, 26 Apr 2023 11:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240952AbjDZPHJ (ORCPT ); Wed, 26 Apr 2023 11:07:09 -0400 X-Greylist: delayed 94 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 26 Apr 2023 08:06:32 PDT Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6470072B4 for ; Wed, 26 Apr 2023 08:06:32 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id b4786a13-e443-11ed-b3cf-005056bd6ce9; Wed, 26 Apr 2023 18:04:56 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Wed, 26 Apr 2023 18:04:55 +0300 To: Rohit Agarwal Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com, manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver Message-ID: References: <1682327030-25535-1-git-send-email-quic_rohiagar@quicinc.com> <1682327030-25535-3-git-send-email-quic_rohiagar@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1682327030-25535-3-git-send-email-quic_rohiagar@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Apr 24, 2023 at 02:33:50PM +0530, Rohit Agarwal kirjoitti: > Add initial Qualcomm SDX75 pinctrl driver to support pin configuration > with pinctrl framework for SDX75 SoC. > While at it, reordering the SDX65 entry. ... > +#define FUNCTION(fname) \ > + [msm_mux_##fname] = { \ > + .name = #fname, \ > + .groups = fname##_groups, \ > + .ngroups = ARRAY_SIZE(fname##_groups), \ > + } PINCTRL_PINFUNCTION() ? ... > +static const struct of_device_id sdx75_pinctrl_of_match[] = { > + {.compatible = "qcom,sdx75-tlmm", .data = &sdx75_pinctrl}, {}, One entry per line. And drop comma in the terminator one. > +}; No MODULE_DEVICE_TABLE()? -- With Best Regards, Andy Shevchenko