From: Simon Horman <simon.horman@corigine.com>
To: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Cc: patrick@stwcx.xyz, Samuel Mendoza-Jonas <sam@mendozajonas.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] net/ncsi: Fix the multi thread manner of NCSI driver
Date: Wed, 26 Apr 2023 21:42:40 +0200 [thread overview]
Message-ID: <ZEl+sL5TMmOaqZNa@corigine.com> (raw)
In-Reply-To: <20230424114742.32933-2-Delphine_CC_Chiu@wiwynn.com>
On Mon, Apr 24, 2023 at 07:47:42PM +0800, Delphine CC Chiu wrote:
> From: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
>
> Currently NCSI driver will send several NCSI commands back
> to back without waiting the response of previous NCSI command
> or timeout in some state when NIC have multi channel. This
> operation against the single thread manner defined by NCSI
> SPEC(section 6.3.2.3 in DSP0222_1.1.1).
>
> 1. Fix the problem of NCSI driver that sending command back
> to back without waiting the response of previos NCSI command
Hi Delphine,
a minor nit from my side: s/previos/previous/
> or timeout to meet the single thread manner.
> 2. According to NCSI SPEC(section 6.2.13.1 in DSP0222_1.1.1),
> we should probe one channel at a time by sending NCSI commands
> (Clear initial state, Get version ID, Get capabilities...), than
> repeat this steps until the max number of channels which we got
> from NCSI command (Get capabilities) has been probed.
>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
prev parent reply other threads:[~2023-04-26 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 11:47 [PATCH v1 0/1] Fix the multi thread manner of NCSI driver Delphine CC Chiu
2023-04-24 11:47 ` [PATCH v1 1/1] net/ncsi: " Delphine CC Chiu
2023-04-25 1:21 ` Jakub Kicinski
2023-04-26 19:42 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEl+sL5TMmOaqZNa@corigine.com \
--to=simon.horman@corigine.com \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=patrick@stwcx.xyz \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).