From: Simon Horman <simon.horman@corigine.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, jarkko.nikula@linux.intel.com,
andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, jsd@semihalf.com,
ose.Abreu@synopsys.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, linux-i2c@vger.kernel.org,
linux-gpio@vger.kernel.org, mengyuanlou@net-swift.com
Subject: Re: [RFC PATCH net-next v5 1/9] net: txgbe: Add software nodes to support phylink
Date: Fri, 28 Apr 2023 22:47:42 +0200 [thread overview]
Message-ID: <ZEww7uBf5HYy7AqP@corigine.com> (raw)
In-Reply-To: <20230426071434.452717-2-jiawenwu@trustnetic.com>
On Wed, Apr 26, 2023 at 03:14:26PM +0800, Jiawen Wu wrote:
...
> @@ -663,10 +665,21 @@ static int txgbe_probe(struct pci_dev *pdev,
> "0x%08x", etrack_id);
> }
>
> - err = register_netdev(netdev);
> + txgbe = devm_kzalloc(&pdev->dev, sizeof(*txgbe), GFP_KERNEL);
> + if (!txgbe)
Hi Jiawen,
I think yo need to set err here.
> + goto err_release_hw;
> +
...
next prev parent reply other threads:[~2023-04-28 20:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 7:14 [RFC PATCH net-next v5 0/9] TXGBE PHYLINK support Jiawen Wu
2023-04-26 7:14 ` [RFC PATCH net-next v5 1/9] net: txgbe: Add software nodes to support phylink Jiawen Wu
2023-04-28 20:47 ` Simon Horman [this message]
2023-04-26 7:14 ` [RFC PATCH net-next v5 2/9] i2c: designware: Add driver support for Wangxun 10Gb NIC Jiawen Wu
2023-04-26 15:45 ` andy.shevchenko
2023-04-27 2:15 ` Jiawen Wu
2023-04-27 5:57 ` Andy Shevchenko
2023-04-27 6:56 ` Jiawen Wu
2023-04-27 10:42 ` Andy Shevchenko
2023-04-27 7:25 ` Jiawen Wu
2023-04-26 7:14 ` [RFC PATCH net-next v5 3/9] net: txgbe: Register fixed rate clock Jiawen Wu
2023-04-26 7:14 ` [RFC PATCH net-next v5 4/9] net: txgbe: Register I2C platform device Jiawen Wu
2023-04-26 16:19 ` andy.shevchenko
2023-04-26 7:14 ` [RFC PATCH net-next v5 5/9] net: txgbe: Add SFP module identify Jiawen Wu
2023-04-26 7:14 ` [RFC PATCH net-next v5 6/9] net: txgbe: Support GPIO to SFP socket Jiawen Wu
2023-04-26 7:14 ` [RFC PATCH net-next v5 7/9] net: pcs: Add 10GBASE-R mode for Synopsys Designware XPCS Jiawen Wu
2023-05-02 8:03 ` Russell King (Oracle)
2023-04-26 7:14 ` [RFC PATCH net-next v5 8/9] net: txgbe: Implement phylink pcs Jiawen Wu
2023-04-26 7:14 ` [RFC PATCH net-next v5 9/9] net: txgbe: Support phylink MAC layer Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEww7uBf5HYy7AqP@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=ose.Abreu@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).