From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8CC6628 for ; Fri, 12 May 2023 00:11:30 +0000 (UTC) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7063F1FEB; Thu, 11 May 2023 17:11:29 -0700 (PDT) Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-3f4de077aaaso22506721cf.1; Thu, 11 May 2023 17:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683850288; x=1686442288; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WAhrsdsfHuWNLZ+EDCW5kgxhkxTw8oftjQzitGQyt1o=; b=KQX4+5F16DPv+Xwar3ioHwB7+1rHKkv1+Ld3hHyLG8nmJjBStqzheDZQfV5bb/DdNo RDEA4KpEvrpCfAlvLS1stjVEmnjkeYLADIuh4MPMgSULVFXu39CwL+EbSJCd+oMAtcum KfW96M9ik14xxIY+pMy+CAFF2hZH3IZahl3qZyTzlSg8Nnd8NKOexfZu4ITw2XvIp9Y2 GPgL5A9XPOywxpJkoyzMeQ8V1orpiDmVslSB61JASslZSdKX22Kxc3juOy4FbJvWDQRL Je0vlHHGdVwJKAyFT/sfWsIoqXn6kb4h3pIFl2yvm+9v4YxZchCdXpTFR8qcFfsmY7n7 iKjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683850288; x=1686442288; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WAhrsdsfHuWNLZ+EDCW5kgxhkxTw8oftjQzitGQyt1o=; b=TcuwxMrcwX7DvR0LA0NBbhy3nvbTT89gjwWxdGBcZ47Xoayb3/Ir/4GAdJ31Ak22N3 b4RA9XcXZMPqEDXlGP1uGKQAeV3lsQH06gBGpdBjeRnsm+Mn3CoBiBX5gVr65DztfCJZ sV+ECNCY4CTzl2T6LUqO4py1k61arpu2gdaLVssh9qAjNMYPfNGcoUkYGZSYEjbZfaQj N0mi//D7Wd2FQFZEcQmJeQz3nzDXoq53MTlAA2bV5mpeWtotdc3FVNabGt/hoc7Cab4D F2KAUYc5e+HAVZMHUab+aEtgaFSfgZoVnYsjKlbaKKxlo9SjZ0CAkJaJydLtZZKYjua/ 8m3A== X-Gm-Message-State: AC+VfDxca41IxdEJ9+4Ls6AJtlwI2vyShAR1pu34D42kSXQaNpFqkZhb Kuh8BudZ4CnYV4cbTk72Gg== X-Google-Smtp-Source: ACHHUZ6sWGN7h27F/dhnj1tNOuiDXqvHV7ysNicGCWRSWdtkQ3mjrAVDxwrNjgnouEBe9UkOIUkH8g== X-Received: by 2002:ac8:7d42:0:b0:3f3:8819:67ec with SMTP id h2-20020ac87d42000000b003f3881967ecmr30535137qtb.15.1683850288526; Thu, 11 May 2023 17:11:28 -0700 (PDT) Received: from C02FL77VMD6R.googleapis.com ([2600:1700:d860:12b0:8d4a:f604:7849:d619]) by smtp.gmail.com with ESMTPSA id x14-20020a05620a14ae00b007591cc41ed6sm152731qkj.25.2023.05.11.17.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 17:11:28 -0700 (PDT) Date: Thu, 11 May 2023 17:11:23 -0700 From: Peilin Ye To: Jakub Kicinski Cc: Jiri Pirko , Daniel Borkmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Peilin Ye , John Fastabend , Vlad Buslov , Pedro Tammela , Hillf Danton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Cong Wang Subject: Re: [PATCH net 6/6] net/sched: qdisc_destroy() old ingress and clsact Qdiscs before grafting Message-ID: References: <20230508183324.020f3ec7@kernel.org> <20230510161559.2767b27a@kernel.org> <20230511162023.3651970b@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, May 11, 2023 at 04:46:33PM -0700, Peilin Ye wrote: > On Thu, May 11, 2023 at 04:20:23PM -0700, Jakub Kicinski wrote: > > > But I see your point, thanks for the suggestion! I'll try ->init() and > > > create v2. > > > > ->init() may be too early, aren't there any error points which could > > prevent the Qdisc from binding after ->init() was called? > > You're right, it's in qdisc_create(), argh... ->destroy() is called for all error points between ->init() and dev_graft_qdisc(). I'll try handling it in ->destroy(). Thanks, Peilin Ye