* [PATCH] Fix grammar in ip-rule(8) man page
@ 2023-05-08 8:05 Bilal Khan
2023-05-11 9:15 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Bilal Khan @ 2023-05-08 8:05 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: majordomo, netdev
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
Hey there,
I have identified a small grammatical error in the ip-rule(8) man
page, and have created a patch to fix it. The current first line of
the DESCRIPTION section reads:
> ip rule manipulates rules in the routing policy database control the route selection algorithm.
This sentence contains a grammatical error, as "control" should either
be changed to "that controls" (to apply to "database") or "to control"
(to apply to "manipulates"). I have updated the sentence to read:
> ip rule manipulates rules in the routing policy database that controls the route selection algorithm.
This change improves the readability and clarity of the ip-rule(8) man
page and makes it easier for users to understand how to use the IP
rule command.
I have attached the patch file by the name
"0001-fixed-the-grammar-in-ip-rule-8-man-page.patch" to this email and
would appreciate any feedback or suggestions for improvement.
Thank you!
[-- Attachment #2: 0001-fixed-the-grammar-in-ip-rule-8-man-page.patch --]
[-- Type: text/x-patch, Size: 908 bytes --]
From 26213b82b4d3c5bbe7bca5ab5378c55f1e1c9e78 Mon Sep 17 00:00:00 2001
From: Bilal Khan <bilalkhanrecovered@gmail.com>
Date: Tue, 2 May 2023 14:44:32 +0500
Subject: [PATCH] fixed the grammar in ip-rule(8) man page
a small grammatical error has been idenfied in the ip-rule(8) man page
Signed-off-by: Bilal Khan <bilalkhanrecovered@gmail.com>
---
man/man8/ip-rule.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8
index 743d88c6..c90d0e87 100644
--- a/man/man8/ip-rule.8
+++ b/man/man8/ip-rule.8
@@ -88,7 +88,7 @@ ip-rule \- routing policy database management
.SH DESCRIPTION
.I ip rule
manipulates rules
-in the routing policy database control the route selection algorithm.
+in the routing policy database that controls the route selection algorithm.
.P
Classic routing algorithms used in the Internet make routing decisions
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix grammar in ip-rule(8) man page
2023-05-08 8:05 [PATCH] Fix grammar in ip-rule(8) man page Bilal Khan
@ 2023-05-11 9:15 ` Simon Horman
2023-05-11 15:50 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2023-05-11 9:15 UTC (permalink / raw)
To: Bilal Khan; +Cc: Stephen Hemminger, majordomo, netdev
On Mon, May 08, 2023 at 01:05:02PM +0500, Bilal Khan wrote:
> Hey there,
>
> I have identified a small grammatical error in the ip-rule(8) man
> page, and have created a patch to fix it. The current first line of
> the DESCRIPTION section reads:
>
> > ip rule manipulates rules in the routing policy database control the route selection algorithm.
>
> This sentence contains a grammatical error, as "control" should either
> be changed to "that controls" (to apply to "database") or "to control"
> (to apply to "manipulates"). I have updated the sentence to read:
>
> > ip rule manipulates rules in the routing policy database that controls the route selection algorithm.
>
> This change improves the readability and clarity of the ip-rule(8) man
> page and makes it easier for users to understand how to use the IP
> rule command.
>
> I have attached the patch file by the name
> "0001-fixed-the-grammar-in-ip-rule-8-man-page.patch" to this email and
> would appreciate any feedback or suggestions for improvement.
>
> Thank you!
FWIIW, I'm not sure that an attachment is the right way to submit patches.
It's more usual to use something like git send-email or b4 to send
basically what is in your attachment.
I'm sure Stephen will provide guidance if he'd like things done a different
way.
> From 26213b82b4d3c5bbe7bca5ab5378c55f1e1c9e78 Mon Sep 17 00:00:00 2001
> From: Bilal Khan <bilalkhanrecovered@gmail.com>
> Date: Tue, 2 May 2023 14:44:32 +0500
> Subject: [PATCH] fixed the grammar in ip-rule(8) man page
>
> a small grammatical error has been idenfied in the ip-rule(8) man page
>
> Signed-off-by: Bilal Khan <bilalkhanrecovered@gmail.com>
In any case, the change does look good to me.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> man/man8/ip-rule.8 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8
> index 743d88c6..c90d0e87 100644
> --- a/man/man8/ip-rule.8
> +++ b/man/man8/ip-rule.8
> @@ -88,7 +88,7 @@ ip-rule \- routing policy database management
> .SH DESCRIPTION
> .I ip rule
> manipulates rules
> -in the routing policy database control the route selection algorithm.
> +in the routing policy database that controls the route selection algorithm.
>
> .P
> Classic routing algorithms used in the Internet make routing decisions
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix grammar in ip-rule(8) man page
2023-05-11 9:15 ` Simon Horman
@ 2023-05-11 15:50 ` Stephen Hemminger
2023-05-12 8:15 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2023-05-11 15:50 UTC (permalink / raw)
To: Simon Horman; +Cc: Bilal Khan, majordomo, netdev
On Thu, 11 May 2023 11:15:23 +0200
Simon Horman <simon.horman@corigine.com> wrote:
> On Mon, May 08, 2023 at 01:05:02PM +0500, Bilal Khan wrote:
> > Hey there,
> >
> > I have identified a small grammatical error in the ip-rule(8) man
> > page, and have created a patch to fix it. The current first line of
> > the DESCRIPTION section reads:
> >
> > > ip rule manipulates rules in the routing policy database control the route selection algorithm.
> >
> > This sentence contains a grammatical error, as "control" should either
> > be changed to "that controls" (to apply to "database") or "to control"
> > (to apply to "manipulates"). I have updated the sentence to read:
> >
> > > ip rule manipulates rules in the routing policy database that controls the route selection algorithm.
> >
> > This change improves the readability and clarity of the ip-rule(8) man
> > page and makes it easier for users to understand how to use the IP
> > rule command.
> >
> > I have attached the patch file by the name
> > "0001-fixed-the-grammar-in-ip-rule-8-man-page.patch" to this email and
> > would appreciate any feedback or suggestions for improvement.
> >
> > Thank you!
>
> FWIIW, I'm not sure that an attachment is the right way to submit patches.
> It's more usual to use something like git send-email or b4 to send
> basically what is in your attachment.
>
> I'm sure Stephen will provide guidance if he'd like things done a different
> way.
Applied and did small fixups. Novices get more leeway in initial patch submissions.
The main requirements are that it correct, applies clean, and has required DCO.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix grammar in ip-rule(8) man page
2023-05-11 15:50 ` Stephen Hemminger
@ 2023-05-12 8:15 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-05-12 8:15 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Bilal Khan, majordomo, netdev
On Thu, May 11, 2023 at 08:50:09AM -0700, Stephen Hemminger wrote:
> On Thu, 11 May 2023 11:15:23 +0200
> Simon Horman <simon.horman@corigine.com> wrote:
>
> > On Mon, May 08, 2023 at 01:05:02PM +0500, Bilal Khan wrote:
> > > Hey there,
> > >
> > > I have identified a small grammatical error in the ip-rule(8) man
> > > page, and have created a patch to fix it. The current first line of
> > > the DESCRIPTION section reads:
> > >
> > > > ip rule manipulates rules in the routing policy database control the route selection algorithm.
> > >
> > > This sentence contains a grammatical error, as "control" should either
> > > be changed to "that controls" (to apply to "database") or "to control"
> > > (to apply to "manipulates"). I have updated the sentence to read:
> > >
> > > > ip rule manipulates rules in the routing policy database that controls the route selection algorithm.
> > >
> > > This change improves the readability and clarity of the ip-rule(8) man
> > > page and makes it easier for users to understand how to use the IP
> > > rule command.
> > >
> > > I have attached the patch file by the name
> > > "0001-fixed-the-grammar-in-ip-rule-8-man-page.patch" to this email and
> > > would appreciate any feedback or suggestions for improvement.
> > >
> > > Thank you!
> >
> > FWIIW, I'm not sure that an attachment is the right way to submit patches.
> > It's more usual to use something like git send-email or b4 to send
> > basically what is in your attachment.
> >
> > I'm sure Stephen will provide guidance if he'd like things done a different
> > way.
>
> Applied and did small fixups. Novices get more leeway in initial patch submissions.
> The main requirements are that it correct, applies clean, and has required DCO.
Yes, of course. Thanks Stephen.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Fix grammar in ip-rule(8) man page
@ 2023-04-27 6:41 Bilal Khan
2023-04-27 15:52 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Bilal Khan @ 2023-04-27 6:41 UTC (permalink / raw)
To: majordomo; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
Hey there,
I have identified a small grammatical error in the ip-rule(8) man
page, and have created a patch to fix it. The current first line of
the DESCRIPTION section reads:
> ip rule manipulates rules in the routing policy database control the route selection algorithm.
This sentence contains a grammatical error, as "control" should either
be changed to "that controls" (to apply to "database") or "to control"
(to apply to "manipulates"). I have updated the sentence to read:
> ip rule manipulates rules in the routing policy database that controls the route selection algorithm.
This change improves the readability and clarity of the ip-rule(8) man
page and makes it easier for users to understand how to use the ip
rule command.
I have attached the patch file
"0001-Fix-grammar-in-ip-rule-8-man-page.patch" to this email and would
appreciate any feedback or suggestions for improvement.
[-- Attachment #2: 0001-Fix-grammar-in-ip-rule-8-man-page.patch --]
[-- Type: text/x-patch, Size: 1238 bytes --]
From be8f5ba2360977b6be697d036bd9515abe51dc85 Mon Sep 17 00:00:00 2001
From: Bilal Khan <bilalkhanrecovered@gmail.com>
Date: Wed, 26 Apr 2023 18:15:03 +0500
Subject: [PATCH] Fix grammar in ip-rule(8) man page
The current description of the ip-rule(8) man page contains a grammatical error that makes it difficult to understand.
This commit fixes the error by changing the word 'control' to 'that controls', which clarifies the meaning of the sentence. The change was made in the DESCRIPTION section of the man page.
This commit will improve the readability and clarity of the ip-rule(8) man page and make it easier for users to understand how to use the ip rule command.
---
man/man8/ip-rule.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8
index 743d88c6..c90d0e87 100644
--- a/man/man8/ip-rule.8
+++ b/man/man8/ip-rule.8
@@ -88,7 +88,7 @@ ip-rule \- routing policy database management
.SH DESCRIPTION
.I ip rule
manipulates rules
-in the routing policy database control the route selection algorithm.
+in the routing policy database that controls the route selection algorithm.
.P
Classic routing algorithms used in the Internet make routing decisions
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix grammar in ip-rule(8) man page
2023-04-27 6:41 Bilal Khan
@ 2023-04-27 15:52 ` Stephen Hemminger
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2023-04-27 15:52 UTC (permalink / raw)
To: Bilal Khan; +Cc: majordomo, netdev
On Thu, 27 Apr 2023 11:41:48 +0500
Bilal Khan <bilalkhanrecovered@gmail.com> wrote:
> Hey there,
>
> I have identified a small grammatical error in the ip-rule(8) man
> page, and have created a patch to fix it. The current first line of
> the DESCRIPTION section reads:
>
> > ip rule manipulates rules in the routing policy database control the route selection algorithm.
>
> This sentence contains a grammatical error, as "control" should either
> be changed to "that controls" (to apply to "database") or "to control"
> (to apply to "manipulates"). I have updated the sentence to read:
>
> > ip rule manipulates rules in the routing policy database that controls the route selection algorithm.
>
> This change improves the readability and clarity of the ip-rule(8) man
> page and makes it easier for users to understand how to use the ip
> rule command.
>
> I have attached the patch file
> "0001-Fix-grammar-in-ip-rule-8-man-page.patch" to this email and would
> appreciate any feedback or suggestions for improvement.
Patch is missing signed off by. For legal reasons patches are only accepted
with a valid signed-off-by which is Developers Certificate of Origin.
You can use kernel checkpatch to check iproute2 patches as well.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-12 8:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-08 8:05 [PATCH] Fix grammar in ip-rule(8) man page Bilal Khan
2023-05-11 9:15 ` Simon Horman
2023-05-11 15:50 ` Stephen Hemminger
2023-05-12 8:15 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2023-04-27 6:41 Bilal Khan
2023-04-27 15:52 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).