From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Yan Wang <rk.code@outlook.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] net: mdiobus: Add a function to deassert reset
Date: Fri, 12 May 2023 10:02:05 +0100 [thread overview]
Message-ID: <ZF4AjX6csKkVJzht@shell.armlinux.org.uk> (raw)
In-Reply-To: <KL1PR01MB54486A247214CC72CAB5A433E6759@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
On Fri, May 12, 2023 at 03:08:53PM +0800, Yan Wang wrote:
> + gpiod_set_value_cansleep(reset, gpiod_is_active_low(reset));
> + fsleep(reset_assert_delay);
> + gpiod_set_value_cansleep(reset, !gpiod_is_active_low(reset));
Andrew, one of the phylib maintainers and thus is responsible for code
in the area you are touching. Andrew has complained about the above
which asserts and then deasserts reset on two occasions now, explained
why it is wrong, but still the code persists in doing this.
I am going to add my voice as another phylib maintainer to this and say
NO to this code, for the exact same reasons that Andrew has given.
You now have two people responsible for the code in question telling
you that this is the wrong approach.
Until this is addressed in some way, it is pointless you posting
another version of this patch.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-05-12 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 7:08 [PATCH v5] net: mdiobus: Add a function to deassert reset Yan Wang
2023-05-12 9:02 ` Russell King (Oracle) [this message]
2023-05-12 9:28 ` Yan Wang
2023-05-12 9:41 ` Russell King (Oracle)
2023-05-12 9:50 ` Yan Wang
2023-05-12 13:37 ` Alexander Stein
2023-05-12 16:30 ` Yan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF4AjX6csKkVJzht@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rk.code@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).