netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@corigine.com>
To: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com
Subject: Re: [PATCH net-next v4 1/7] net: wangxun: libwx add tx offload functions
Date: Fri, 12 May 2023 16:16:30 +0200	[thread overview]
Message-ID: <ZF5KPjbVHtSpvH2x@corigine.com> (raw)
In-Reply-To: <20230510093845.47446-2-mengyuanlou@net-swift.com>

On Wed, May 10, 2023 at 05:38:39PM +0800, Mengyuan Lou wrote:
> Add tx offload functions for wx_xmit_frame_ring which
> includes wx_encode_tx_desc_ptype, wx_tso and wx_tx_csum.
> which supports ngbe and txgbe to implement tx offload
> function.
> 
> Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>

...

> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> index 32f952d93009..70f5fd168e40 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_type.h
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h
> @@ -6,6 +6,7 @@
>  
>  #include <linux/bitfield.h>
>  #include <linux/netdevice.h>
> +#include <net/ip.h>
>  
>  #define WX_NCSI_SUP                             0x8000
>  #define WX_NCSI_MASK                            0x8000
> @@ -315,9 +316,6 @@
>  #define TXD_USE_COUNT(S)     DIV_ROUND_UP((S), WX_MAX_DATA_PER_TXD)
>  #define DESC_NEEDED          (MAX_SKB_FRAGS + 4)
>  
> -/* Ether Types */
> -#define WX_ETH_P_CNM                 0x22E7
> -
>  #define WX_CFG_PORT_ST               0x14404
>  
>  /******************* Receive Descriptor bit definitions **********************/

nit: this comment is not in Kernel doc format, so it should not start with /**

  reply	other threads:[~2023-05-12 14:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10  9:38 [PATCH net-next v4 0/7] Wangxun netdev features support Mengyuan Lou
2023-05-10  9:38 ` [PATCH net-next v4 1/7] net: wangxun: libwx add tx offload functions Mengyuan Lou
2023-05-12 14:16   ` Simon Horman [this message]
2023-05-10  9:38 ` [PATCH net-next v4 2/7] net: wangxun: libwx add rx " Mengyuan Lou
2023-05-10 11:43   ` Yunsheng Lin
2023-05-11  8:34     ` mengyuanlou
2023-05-11 11:48       ` Yunsheng Lin
2023-05-12  6:00         ` mengyuanlou
2023-05-12 11:41           ` Yunsheng Lin
2023-05-15  1:31             ` mengyuanlou
2023-05-15  1:36               ` mengyuanlou
2023-05-10  9:38 ` [PATCH net-next v4 3/7] net: wangxun: Implement vlan add and kill functions Mengyuan Lou
2023-05-11 12:21   ` Yunsheng Lin
2023-05-12  6:40     ` mengyuanlou
2023-05-10  9:38 ` [PATCH net-next v4 4/7] net: ngbe add netdev features support Mengyuan Lou
2023-05-10  9:38 ` [PATCH net-next v4 5/7] net: ngbe: Implement vlan add and remove ops Mengyuan Lou
2023-05-10  9:38 ` [PATCH net-next v4 6/7] net: txgbe add netdev features support Mengyuan Lou
2023-05-10  9:38 ` [PATCH net-next v4 7/7] net: txgbe: Implement vlan add and remove ops Mengyuan Lou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZF5KPjbVHtSpvH2x@corigine.com \
    --to=simon.horman@corigine.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=mengyuanlou@net-swift.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).